From: Junio C Hamano <gitster@pobox.com>
To: "Philip Oakley" <philipoakley@iee.org>
Cc: "Eric Sunshine" <sunshine@sunshineco.com>,
"Alexander Kuleshov" <kuleshovmail@gmail.com>,
<git@vger.kernel.org>
Subject: Re: [PATCH RFC 1/3] add: add new --exclude option to git add
Date: Sun, 15 Mar 2015 14:50:41 -0700 [thread overview]
Message-ID: <xmqq4mpmszf2.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <D9562ECC995343B3A51D449DC2B46CBC@PhilipOakley> (Philip Oakley's message of "Sun, 15 Mar 2015 21:12:49 -0000")
"Philip Oakley" <philipoakley@iee.org> writes:
> Maybe He/We would be better off adjusting the documentation such that
> these 'magic' capabilities are brought out of their hiding places into
> regular view - e.g. a paragraph within the 'git add' documentation
> (and/or other commands) showing how such excludes are easily done with
> a few simple keystrokes....
I agree documenting is good, but I do not think it belongs to "git
add". For example, shouldn't "git log -- \*.c ':!secret.c'" work
the same way?
> 'git help revisions' doesn't appear to cover it.
Of course not, because "revisions" would cover revisions, and
pathspecs are different animals ;-) Again, I agree there should be a
section somewhere close to the central place that talks about
pathspecs in general and then talk about pathspec magic there.
There are some references in git(1) but they talk about ways to
implicitly enable the magic to _all_ pathspecs, before introducing
the readers to what the magics are and how they can use them.
Perhaps in git(1), before we introduce "GIT COMMANDS", we may want
to have a new section that talks about the general structure of the
Git command line, laying out the general rules such as
* dashed options come first
* revisions and ranges come second
* pathspecs come last
The first one is described in detail in gitcli(7) and how revisions
are spelled is given in gitrevisions(7). How pathspecs are spelled
and used may want to be its own gitpathspecs(7), or if there are not
too many rules, can be spelled out there inline. Either way, we
would want a brief section in git(1) to serve as a jumping board for
the former two, at least. Also descriptions for --literal-pathspecs
and friends would want to refer to either the section or have a
direct reference to gitpathspecs(7) if we are going to write it a
new file.
next prev parent reply other threads:[~2015-03-15 21:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 13:49 [PATCH RFC 1/3] add: add new --exclude option to git add Alexander Kuleshov
2015-03-15 13:50 ` [PATCH 2/3] Documentation/git-add.txt: describe --exclude option Alexander Kuleshov
2015-03-15 18:14 ` Eric Sunshine
2015-03-15 13:50 ` [PATCH 3/3] t3700-add: added test for " Alexander Kuleshov
2015-03-15 18:00 ` Torsten Bögershausen
2015-03-15 18:18 ` Eric Sunshine
2015-03-15 17:39 ` [PATCH RFC 1/3] add: add new --exclude option to git add Philip Oakley
2015-03-15 17:51 ` Torsten Bögershausen
2015-03-15 18:00 ` Alexander Kuleshov
2015-03-16 6:38 ` Torsten Bögershausen
2015-03-15 18:03 ` Torsten Bögershausen
2015-03-15 18:12 ` Eric Sunshine
2015-03-15 20:09 ` Junio C Hamano
2015-03-15 21:12 ` Philip Oakley
2015-03-15 21:50 ` Junio C Hamano [this message]
2015-03-16 7:11 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4mpmszf2.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kuleshovmail@gmail.com \
--cc=philipoakley@iee.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.