From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Kyle J. McKay" <mackyle@gmail.com>,
Johan Herland <johan@herland.net>,
git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.0.0-rc0
Date: Tue, 22 Apr 2014 13:12:56 -0700 [thread overview]
Message-ID: <xmqq4n1l3yyf.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140422185829.GB15516@google.com> (Jonathan Nieder's message of "Tue, 22 Apr 2014 11:58:29 -0700")
The following message is a courtesy copy of an article
that has been posted to gmane.comp.version-control.git as well.
Jonathan Nieder <jrnieder@gmail.com> writes:
> Hm, perhaps we should introduce a 'no-prefix' option to work around
> this.
> ...
>> |diff --git a/git-svn.perl b/git-svn.perl
>> |index 7349ffea..284f458a 100755
>> |--- a/git-svn.perl
>> |+++ b/git-svn.perl
>> |@@ -149,7 +149,7 @@ my ($_trunk, @_tags, @_branches, $_stdlayout);
>> my %icv;
>> my %init_opts = ( 'template=s' => \$_template, 'shared:s' => \$_shared,
>> 'trunk|T=s' => \$_trunk, 'tags|t=s@' => \@_tags,
>> 'branches|b=s@' => \@_branches, 'prefix=s' => \$_prefix,
> + 'no-prefix' => sub { $_prefix = "" },
>
>> 'stdlayout|s' => \$_stdlayout,
>> 'minimize-url|m!' => \$Git::SVN::_minimize_url,
>> 'no-metadata' => sub { $icv{noMetadata} = 1 },
>
> That way, normal usage of --prefix would still be consistent with
> other git commands that prefer the form with argument attached
> (--prefix=foo, not --prefix foo; see gitcli(7)).
>
> Thoughts?
I do not think that it is a good idea to use "--no-anything" for
something that is not a boolean.
I can buy "--old-default-prefix", or "--empty-prefix", but running
"git svn --prefix ''" (or "--prefix=''") would be OK and logically
consistent anyway (i.e. the option tells us what string to add after
"refs/remotes/", and the old default that everybody hated were to
use an empty string), so...
next prev parent reply other threads:[~2014-04-22 20:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 19:37 [ANNOUNCE] Git v2.0.0-rc0 Junio C Hamano
2014-04-19 1:13 ` Johan Herland
2014-04-19 7:20 ` Junio C Hamano
2014-04-20 19:08 ` Felipe Contreras
2014-04-20 21:14 ` Junio C Hamano
2014-04-22 11:16 ` Kyle J. McKay
2014-04-22 18:58 ` Jonathan Nieder
2014-04-22 20:12 ` Junio C Hamano [this message]
2014-04-22 21:00 ` Jonathan Nieder
2014-04-22 21:26 ` Junio C Hamano
2014-04-22 22:11 ` Jonathan Nieder
2014-04-22 22:25 ` brian m. carlson
2014-04-22 22:47 ` Junio C Hamano
2014-04-23 7:33 ` Johan Herland
2014-04-23 16:40 ` Junio C Hamano
2014-04-22 19:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4n1l3yyf.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=jrnieder@gmail.com \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.