All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: git@vger.kernel.org
Subject: [microproject idea]
Date: Tue, 04 Mar 2014 13:11:25 -0800	[thread overview]
Message-ID: <xmqq4n3dk6te.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1393921868-4382-1-git-send-email-mhagger@alum.mit.edu> (Michael Haggerty's message of "Tue, 4 Mar 2014 09:31:08 +0100")

Find places where we scan a string twice unnecessarily, once with
strchr() and then with strlen(), e.g.

	const char *colon = strchr(name, ':');
	int namelen = colon ? colon - name : strlen(name);

and rewrite such a pattern using strchrnul() as appropriate.

The above example can become

	const char *colon = strchrnul(name, ':');
        int namelen = colon - name;

      parent reply	other threads:[~2014-03-04 21:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04  8:31 [PATCH v2] cache_tree_find(): remove redundant checks Michael Haggerty
2014-03-04  9:40 ` David Kastrup
2014-03-04 10:22   ` Michael Haggerty
2014-03-04 10:34     ` David Kastrup
2014-03-04 21:05 ` Junio C Hamano
2014-03-04 22:24   ` Michael Haggerty
2014-03-04 23:18     ` Junio C Hamano
2014-03-05 17:57       ` Junio C Hamano
2014-03-05  4:38   ` David Kastrup
2014-03-05 18:40     ` Junio C Hamano
2014-03-04 21:11 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4n3dk6te.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.