All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org,  ps@pks.im,  sandals@crustytoothpaste.net
Subject: Re: [PATCH v4] Move rust gitcore crate to a different subdirectory
Date: Thu, 10 Sep 2026 10:45:58 -0700	[thread overview]
Message-ID: <xmqq5x0df19l.fsf@gitster.g> (raw)
In-Reply-To: <20260910121056.2749578-1-mh@glandium.org> (Mike Hommey's message of "Thu, 10 Sep 2026 21:10:56 +0900")

Mike Hommey <mh@glandium.org> writes:

> Subject: Re: [PATCH v4] Move rust gitcore crate to a different subdirectory

Documentation/SubmittingPatches::[[summary-section]]

> Having `Cargo.toml` at the top-level of the repository implies that one
> can run `cargo build` directly, but this doesn't produce anything useful
> on its own.
>
> Additionally, when including the git source as a submodule of a Rust
> project, it prevents the git source from being included at all in the
> crate package because cargo skips directories that contain a Cargo.toml,
> assuming that everything in the directory is relevant to the crate.
>
> Move all Rust-specific files into a dedicated `rust/` subdirectory.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---

This still leaves the source tree in somewhat inconsistent state.

https://github.com/git/git/actions/runs/34505483626/job/102966561269#step:5:120

I do not offhand know if ci/run-rust-checks.sh needs updating or the
moving of files needs tweaking to avoid the breakage, though.

      reply	other threads:[~2026-09-10 17:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 23:22 [RFC PATCH] Move rust gitcore crate to a different subdirectory Mike Hommey
2026-02-05  0:10 ` brian m. carlson
2026-02-05  1:45   ` Mike Hommey
2026-02-05  2:06     ` brian m. carlson
2026-02-05  4:55       ` Mike Hommey
2026-02-09 22:48 ` [PATCH v2] " Mike Hommey
2026-09-09  1:38   ` [PATCH v3] " Mike Hommey
2026-09-09 19:54     ` Junio C Hamano
2026-09-10 12:09       ` Mike Hommey
2026-09-09 21:13     ` brian m. carlson
2026-09-10 12:05       ` Mike Hommey
2026-09-10  6:27     ` Tuomas Ahola
2026-09-10 12:21       ` Junio C Hamano
2026-09-10 12:10     ` [PATCH v4] " Mike Hommey
2026-09-10 17:45       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5x0df19l.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mh@glandium.org \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.