From: Junio C Hamano <gitster@pobox.com>
To: Jishnu C K <jishnuck26@gmail.com>
Cc: Justin Tobler <jltobler@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] help: prompt user to run corrected command on typo
Date: Fri, 19 Jun 2026 09:37:58 -0700 [thread overview]
Message-ID: <xmqq5x3elc49.fsf@gitster.g> (raw)
In-Reply-To: <6a34dc40.2c570c9e.381c97.203f@mx.google.com> (Jishnu C. K.'s message of "Thu, 18 Jun 2026 23:05:52 -0700 (PDT)")
Jishnu C K <jishnuck26@gmail.com> writes:
> You're right that `help.autocorrect=prompt` exists and is similar.
> Our change differs in two ways:
>
> 1. No configuration needed. The existing prompt mode requires the user
I do not particularly see it as an advantage.
> 2. The prompt includes the original arguments. `help.autocorrect=prompt`
> shows only:
>
> Run 'checkout' instead [y/N]?
>
> Our prompt shows the full corrected invocation:
>
> Did you mean 'git checkout neo'? [y/N]
>
> This lets the user confirm exactly what will run, including their
> original arguments, before pressing 'y'.
This may be an improvement, but is there a reason why such a change
must be done as a parallel and unrelated (re)implementation and not
as an incrementa improvement to the code that implements the
existing feature?
next prev parent reply other threads:[~2026-06-19 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 14:26 [PATCH] help: prompt user to run corrected command on typo calicomills
2026-06-18 17:48 ` Justin Tobler
2026-06-19 6:05 ` Jishnu C K
2026-06-19 16:24 ` Justin Tobler
2026-06-19 16:37 ` Junio C Hamano [this message]
2026-06-19 17:04 ` [PATCH v2] help: include arguments in autocorrect=prompt message Jishnu C K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5x3elc49.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jishnuck26@gmail.com \
--cc=jltobler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.