From: Junio C Hamano <gitster@pobox.com>
To: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2026, #03)
Date: Fri, 15 May 2026 10:46:27 +0900 [thread overview]
Message-ID: <xmqq5x4pe970.fsf@gitster.g> (raw)
In-Reply-To: <CALE2CrTea19qHKbhQK8V+uQJgh5GdT+8ia1q2jwr+hf546fnaQ@mail.gmail.com> (Pushkar Singh's message of "Thu, 14 May 2026 23:11:46 +0530")
Pushkar Singh <pushkarkumarsingh1970@gmail.com> writes:
> My thinking was mainly that git stash show normally omits untracked
> changes, while --include-untracked consults the additional untracked
> parent of the stash commit.
>
> I did not see existing coverage specifically checking that behavior,
Ah, OK. Please more explicitly state that it is filling a gap in
test coverage in the proposed log message; it would have helped to
sell the patch better. Adding even more when we already have
adequate coverage is one thing, covering the cases we had no
coverage is totally different matter.
Thanks.
prev parent reply other threads:[~2026-05-15 1:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 9:23 What's cooking in git.git (May 2026, #03) Junio C Hamano
2026-05-12 14:20 ` Pushkar Singh
2026-05-13 16:06 ` Junio C Hamano
2026-05-14 17:41 ` Pushkar Singh
2026-05-15 1:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5x4pe970.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pushkarkumarsingh1970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.