All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Mathias Rav" <m@git.strova.dk>,
	"Phillip Wood" <phillip.wood@dunelm.org.uk>,
	"John Cai" <johncai86@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	"Patrick Steinhardt" <ps@pks.im>,
	git@vger.kernel.org, "Karthik Nayak" <karthik.188@gmail.com>
Subject: Re: [PATCH v2] merge-file: fix BUG when --object-id is used in a worktree
Date: Wed, 11 Mar 2026 10:26:41 -0700	[thread overview]
Message-ID: <xmqq5x72qnu6.fsf@gitster.g> (raw)
In-Reply-To: <bcbbdcb3-9c4b-4eb8-9e70-3eb0bd19b32c@app.fastmail.com> (Kristoffer Haugsbakk's message of "Wed, 11 Mar 2026 12:14:11 +0100")

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

> On Wed, Mar 11, 2026, at 07:44, Mathias Rav wrote:
>>[snip]
>> As for the quotes in the commit references, I use gitk's "Copy commit
>> reference" daily and am personally used to the quotes. Since
>> SubmittingPatches seems to give equal preference to --pretty=reference and
>> "Copy commit reference" I didn't think that the quotes were a problem.
>
>> (I wonder how controversial it would be to remove the quotes in gitk.)
>
> Turns out that this has been attempted least once before:
>
> https://lore.kernel.org/git/1472230741-5161-1-git-send-email-dev+git@drbeat.li/

True.

Perhaps something like this patch makes it clear that what the gitk
command gives and what --pretty=reference gives are not identical,
to avoid confusion like this?  I dunno.


 Documentation/SubmittingPatches | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git c/Documentation/SubmittingPatches w/Documentation/SubmittingPatches
index e270ccbe85..fad0b41af0 100644
--- c/Documentation/SubmittingPatches
+++ w/Documentation/SubmittingPatches
@@ -335,7 +335,7 @@ date)", like this:
 ....
 
 The "Copy commit reference" command of gitk can be used to obtain this
-format (with the subject enclosed in a pair of double-quotes), or this
+format (but with the subject enclosed in an extra pair of double-quotes), or this
 invocation of `git show`:
 
 ....

  reply	other threads:[~2026-03-11 17:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 11:46 [PATCH] merge-file: fix BUG when --object-id is used in a worktree Mathias Rav
2026-03-10 12:35 ` Karthik Nayak
2026-03-10 12:49 ` Patrick Steinhardt
2026-03-10 20:01   ` Junio C Hamano
2026-03-11  6:44     ` [PATCH v2] " Mathias Rav
2026-03-11  7:18       ` Kristoffer Haugsbakk
2026-03-11 11:14       ` Kristoffer Haugsbakk
2026-03-11 17:26         ` Junio C Hamano [this message]
2026-03-11 20:16           ` Kristoffer Haugsbakk
2026-03-18 19:40             ` Junio C Hamano
2026-03-18 19:16       ` Mathias Rav
2026-03-18 19:45         ` Junio C Hamano
2026-03-10 13:34 ` [PATCH] " Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5x72qnu6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johncai86@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=m@git.strova.dk \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.