From: Junio C Hamano <gitster@pobox.com>
To: Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>
Cc: git@vger.kernel.org, "D. Ben Knoble" <ben.knoble@gmail.com>,
Patrick Steinhardt <ps@pks.im>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH v4] submodule: fetch missing objects from default remote
Date: Tue, 03 Mar 2026 12:02:17 -0800 [thread overview]
Message-ID: <xmqq5x7cd6ly.fsf@gitster.g> (raw)
In-Reply-To: <CAFcKa=-EH7YD0bjeUyC6EVijTStuFZYOzQHbAnoXRUtY694Khw@mail.gmail.com> (Nasser Grainawi's message of "Tue, 3 Mar 2026 12:26:39 -0700")
Nasser Grainawi <nasser.grainawi@oss.qualcomm.com> writes:
> On Tue, Mar 3, 2026 at 12:00 PM Nasser Grainawi
> <nasser.grainawi@oss.qualcomm.com> wrote:
>>
>> Also, I just noticed I have $pwd in a couple places and need that to be
>> $(pwd), so I will send both those fixes.
>
> Sorry, ignore this. L11 in this script has `pwd=$(pwd)`, so the $pwd
> usage was intentional and not problematic.
Oh, then it would make it easier to fix, actually, since $pwd is
some fixed directory established long before the control flow went
into the subshell so the fix for test_when_finished that are used to
remove things under $pwd/ (not $(pwd)/) would just be the matter of
moving them out of the subshell, setting the finished handlers up
before we go into the subshells.
next prev parent reply other threads:[~2026-03-03 20:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 21:36 [PATCH] Fetch missing submodule objects from default remote Nasser Grainawi
2026-01-13 2:17 ` Jacob Keller
2026-01-13 21:51 ` Ben Knoble
2026-01-13 22:41 ` Nasser Grainawi
2026-01-14 2:19 ` D. Ben Knoble
2026-01-14 14:10 ` Junio C Hamano
2026-01-14 21:22 ` Ben Knoble
2026-01-14 14:05 ` Junio C Hamano
2026-01-14 19:23 ` Nasser Grainawi
2026-01-14 19:48 ` [PATCH v2] submodule: fetch missing " Nasser Grainawi
2026-01-21 0:48 ` Nasser Grainawi
2026-01-22 15:27 ` [PATCH v3] " Nasser Grainawi
2026-01-22 18:49 ` Junio C Hamano
2026-01-22 20:16 ` Jacob Keller
2026-01-22 20:38 ` Junio C Hamano
2026-02-25 21:55 ` Junio C Hamano
2026-03-02 22:06 ` Jacob Keller
2026-02-27 18:29 ` Nasser Grainawi
2026-01-22 21:21 ` Junio C Hamano
2026-01-23 23:26 ` Junio C Hamano
2026-01-24 2:18 ` Junio C Hamano
2026-02-20 23:12 ` Junio C Hamano
2026-02-27 17:20 ` Nasser Grainawi
2026-03-01 2:53 ` [PATCH v4] " Nasser Grainawi
2026-03-02 22:09 ` Jacob Keller
2026-03-02 22:11 ` Junio C Hamano
2026-03-03 2:11 ` Junio C Hamano
2026-03-03 19:00 ` Nasser Grainawi
2026-03-03 19:26 ` Nasser Grainawi
2026-03-03 20:02 ` Junio C Hamano [this message]
2026-03-03 20:09 ` [PATCH v5] " Nasser Grainawi
2026-03-03 20:47 ` Ramsay Jones
2026-03-03 21:26 ` Junio C Hamano
2026-03-03 23:29 ` Nasser Grainawi
2026-03-03 23:40 ` [PATCH v6] " Nasser Grainawi
2026-03-09 23:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5x7cd6ly.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=nasser.grainawi@oss.qualcomm.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.