All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
	 Adam Dinwoodie <git@dinwoodie.org>,
	 jayatheerthkulkarni2005@gmail.com
Subject: Re: v2.25.0-rc0 test failure on cygwin
Date: Tue, 03 Jun 2025 09:11:26 -0700	[thread overview]
Message-ID: <xmqq5xhcpzyp.fsf@gitster.g> (raw)
In-Reply-To: <771677b1-2ce5-40ce-a704-752ff57ba0d3@ramsayjones.plus.com> (Ramsay Jones's message of "Mon, 2 Jun 2025 23:33:18 +0100")

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> I noticed on Friday, while testing the v2.25.0-rc0 build, that test t6137
> failed on cygwin:
>
>   $ tail test-out-2-50-rc0 
>   Test Summary Report
>   -------------------
>   t6137-pathspec-wildcards-literal.sh              (Wstat: 256 (exited 1) Tests: 25 Failed: 11)
>     Failed tests:  2, 7, 9, 11, 14-15, 17, 19, 21, 23, 25
>     Non-zero exit status: 1
>   Files=1023, Tests=30946, 21783 wallclock secs (19.08 usr 42.17 sys + 4031.65 cusr 12965.78 csys = 17058.68 CPU)
>   Result: FAIL
>   make[1]: *** [Makefile:78: prove] Error 1
>   make[1]: Leaving directory '/home/ramsay/git/t'
>   make: *** [Makefile:3286: test] Error 2
>   $ 
>
> A quick squint at the failing tests made it clear that the failure was
> caused by the cygwin build treating a quoted glob character sequence
> (e.g. '\*') as a directory separator char followed by a glob character.

Should we revert ec727e18 (dir.c: literal match with wildcard in
pathspec should still glob, 2025-05-03) before deciding to how to
proceed, as we will be deep in prerelease freeze?

It's not a "fix" for something that is gravely wrong but a glitch
people have lived with almost forever, so it can be reattempted in
the next cycle without hurting much.

Thanks.



  parent reply	other threads:[~2025-06-03 16:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 22:33 v2.25.0-rc0 test failure on cygwin Ramsay Jones
2025-06-02 22:48 ` Ramsay Jones
2025-06-02 22:57   ` Kristoffer Haugsbakk
2025-06-03 14:41 ` JAYATHEERTH K
2025-06-03 16:11 ` Junio C Hamano [this message]
2025-06-03 19:03   ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5xhcpzyp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@dinwoodie.org \
    --cc=git@vger.kernel.org \
    --cc=jayatheerthkulkarni2005@gmail.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.