All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Christian Couder <christian.couder@gmail.com>,
	 git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
	 Taylor Blau <me@ttaylorr.com>,
	 Eric Sunshine <sunshine@sunshineco.com>,
	 Karthik Nayak <karthik.188@gmail.com>,
	 Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	 "brian m . carlson" <sandals@crustytoothpaste.net>,
	 "Randall S . Becker" <rsbecker@nexbridge.com>,
	 Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2] promisor-remote: fix segfault when remote URL is missing
Date: Tue, 11 Mar 2025 16:36:24 -0700	[thread overview]
Message-ID: <xmqq5xkf2l8n.fsf@gitster.g> (raw)
In-Reply-To: <20250311230601.GA72712@coredump.intra.peff.net> (Jeff King's message of "Tue, 11 Mar 2025 19:06:01 -0400")

Jeff King <peff@peff.net> writes:

> Is a configured remote with out a url key really a missing url, though?
> In other contexts it defaults to the name of the remote. E.g.:
>
>   # make a repo so "foo" is a valid url
>   git init foo
>   git -C foo commit --allow-empty bar
>
>   # configure a fetch refspec, but no url!
>   git init
>   git config remote.foo.fetch '+refs/heads/*:refs/remotes/foo/*'
>
>   # now fetching will use the configured refspec with a url of "foo"
>   git fetch foo
>
>   # and git-remote will report it, along with its url
>   git remote ;# shows "foo"
>   git remote --get-url foo ;# also shows "foo"

Yeah, that does sound like a more natural way to look at it.

  reply	other threads:[~2025-03-11 23:36 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10  7:40 [PATCH] promisor-remote: fix segfault when remote URL is missing Christian Couder
2025-03-10 16:29 ` Junio C Hamano
2025-03-11 15:24   ` Christian Couder
2025-03-11 16:57     ` Junio C Hamano
2025-03-11 15:24 ` [PATCH v2] " Christian Couder
2025-03-11 16:59   ` Junio C Hamano
2025-03-12 11:48     ` Christian Couder
2025-03-11 20:48   ` Junio C Hamano
2025-03-12 11:47     ` Christian Couder
2025-03-11 23:06   ` Jeff King
2025-03-11 23:36     ` Junio C Hamano [this message]
2025-03-12 11:47     ` Christian Couder
2025-03-12 11:46   ` [PATCH v3] " Christian Couder
2025-03-12 17:02     ` Junio C Hamano
2025-03-13 10:39       ` Christian Couder
2025-03-13 16:40         ` Junio C Hamano
2025-03-14 14:09           ` Christian Couder
2025-03-14 17:28             ` Junio C Hamano
2025-03-13 10:38     ` [PATCH v4] " Christian Couder
2025-03-13 16:28       ` Junio C Hamano
2025-03-13 17:23         ` Junio C Hamano
2025-03-14 14:10         ` Christian Couder
2025-03-14 14:12       ` [PATCH v5 0/3] "promisor-remote" capability fixes Christian Couder
2025-03-14 14:12         ` [PATCH v5 1/3] promisor-remote: fix segfault when remote URL is missing Christian Couder
2025-03-14 18:59           ` Junio C Hamano
2025-03-18 11:03             ` Christian Couder
2025-03-14 14:12         ` [PATCH v5 2/3] promisor-remote: fix possible issue when no URL is advertised Christian Couder
2025-03-14 14:12         ` [PATCH v5 3/3] promisor-remote: compare remote names case sensitively Christian Couder
2025-03-14 17:28           ` Junio C Hamano
2025-03-18 11:04             ` Christian Couder
2025-03-18 11:00         ` [PATCH v6 0/4] "promisor-remote" capability fixes Christian Couder
2025-03-18 11:00           ` [PATCH v6 1/4] t5710: arrange to delete the client before cloning Christian Couder
2025-03-18 11:00           ` [PATCH v6 2/4] promisor-remote: fix segfault when remote URL is missing Christian Couder
2025-03-18 11:00           ` [PATCH v6 3/4] promisor-remote: fix possible issue when no URL is advertised Christian Couder
2025-03-18 11:00           ` [PATCH v6 4/4] promisor-remote: compare remote names case sensitively Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5xkf2l8n.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=rsbecker@nexbridge.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.