From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Jeff King" <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] t7407: use test_grep
Date: Tue, 07 Jan 2025 11:42:32 -0800 [thread overview]
Message-ID: <xmqq5xmqs95j.fsf@gitster.g> (raw)
In-Reply-To: <f3ab08db-5dff-4da3-a075-7e9b3eaf1f78@app.fastmail.com> (Kristoffer Haugsbakk's message of "Tue, 07 Jan 2025 12:01:14 +0100")
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
> On Tue, Jan 7, 2025, at 08:18, Jeff King wrote:
>> get rid of them.
>>
>> (It is also curious to grep in the expected file in the first place, but
>> that is because we are auto-generating the expectation from a Git
>> command. So this is double-checking it did what we wanted).
>
> Missing “that”? s/it did/that it did/
It is colloquially correct, isn't it?
next prev parent reply other threads:[~2025-01-07 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 7:18 [PATCH] t7407: use test_grep Jeff King
2025-01-07 9:57 ` Patrick Steinhardt
2025-01-07 11:01 ` Kristoffer Haugsbakk
2025-01-07 19:42 ` Junio C Hamano [this message]
2025-01-07 22:09 ` Kristoffer Haugsbakk
2025-01-07 23:36 ` D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xmqs95j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.