All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Ghanshyam Thakkar <shyamthakkar001@gmail.com>,
	 git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
	 Josh Steadmon <steadmon@google.com>,
	 christian.couder@gmail.com,
	 Christian Couder <chriscool@tuxfamily.org>,
	 Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Subject: Re: [GSoC][PATCH v2] t: migrate helper/test-oidmap.c to unit-tests/t-oidmap.c
Date: Tue, 02 Jul 2024 11:55:14 -0700	[thread overview]
Message-ID: <xmqq5xtnsjxp.fsf@gitster.g> (raw)
In-Reply-To: <16e06a6d-5fd0-4132-9d82-5c6f13b7f9ed@gmail.com> (Phillip Wood's message of "Tue, 2 Jul 2024 16:24:54 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

>> +	}
> 	check_int(count, ARRAY_SIZE(key_val));
>
> to check that we iterate over all the entries as well as checking the
> size of the hashmap here.

I think check_int() macro wants the comparison operator in the
middle, but other than that small typo, the suggestion sounds quite
sensible.  If the iterator does not yield anything, the current test
would still pass.

Thanks.

      parent reply	other threads:[~2024-07-02 18:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 17:50 [GSoC][PATCH] t: migrate helper/test-oidmap.c to unit-tests/t-oidmap.c Ghanshyam Thakkar
2024-06-20  9:45 ` Jonathan Nieder
2024-06-25  1:35   ` Ghanshyam Thakkar
2024-06-25 10:14   ` Phillip Wood
2024-06-25 19:16     ` Ghanshyam Thakkar
2024-06-26  8:59       ` phillip.wood123
2024-06-28 12:20 ` [GSoC][PATCH v2] " Ghanshyam Thakkar
2024-07-01 20:32   ` Josh Steadmon
2024-07-01 21:19     ` Junio C Hamano
2024-07-01 21:14   ` Junio C Hamano
2024-07-01 22:20     ` Junio C Hamano
2024-07-02  3:48       ` Ghanshyam Thakkar
2024-07-02 15:17       ` Phillip Wood
2024-07-02 15:24   ` Phillip Wood
2024-07-02 16:25     ` Ghanshyam Thakkar
2024-07-02 18:55     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5xtnsjxp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=phillip.wood123@gmail.com \
    --cc=shyamthakkar001@gmail.com \
    --cc=steadmon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.