All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Taylor Blau <me@ttaylorr.com>,
	 Eric Sunshine <sunshine@sunshineco.com>,
	 Dragan Simic <dsimic@manjaro.org>
Subject: Re: [PATCH v4] add-patch: enforce only one-letter response to prompts
Date: Thu, 23 May 2024 08:58:25 -0700	[thread overview]
Message-ID: <xmqq5xv4wme6.fsf@gitster.g> (raw)
In-Reply-To: <Zk7UsJjhY_FV2z8C@tanuki> (Patrick Steinhardt's message of "Thu, 23 May 2024 07:31:28 +0200")

Patrick Steinhardt <ps@pks.im> writes:

>>    As an experiment, this message has the range-diff at the end, not
>>    before the primary part of the patch text.  I think this format
>>    should be easier to read for reviewers.
>
> Huh, interesting. I do like that format better indeed. You did that
> manually instead of using `--range-diff`, right?

Yes.

To me, "format-patch --range-diff" is a lot more cumbersome to use
than running "format-patch", open the result in Emacs, and then
doing "\C-u \M-! git range-diff ..." to insert its output, as I'll
be opening it in the editor for typofixes anyway.




      reply	other threads:[~2024-05-23 15:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21  0:37 [PATCH] add-patch: response to unknown command Rubén Justo
2024-05-21  7:03 ` Patrick Steinhardt
2024-05-21 12:59   ` Rubén Justo
2024-05-21 15:52   ` Re* " Junio C Hamano
2024-05-21 22:27     ` Taylor Blau
2024-05-21 23:06       ` Junio C Hamano
2024-05-21 23:20     ` [PATCH v2] add-patch: enforce only one-letter response to prompts Junio C Hamano
2024-05-21 23:36       ` Eric Sunshine
2024-05-22  0:49         ` Junio C Hamano
2024-05-22  6:40       ` Dragan Simic
2024-05-22 16:23         ` Junio C Hamano
2024-05-22 19:03           ` Dragan Simic
2024-05-22 20:41             ` Junio C Hamano
2024-05-22 11:07       ` Patrick Steinhardt
2024-05-22 16:27         ` Junio C Hamano
2024-05-22 17:14       ` [PATCH v3] " Junio C Hamano
2024-05-22 17:38         ` Rubén Justo
2024-05-22 19:27           ` Junio C Hamano
2024-05-22 21:45         ` [PATCH v4] " Junio C Hamano
2024-05-23  5:31           ` Patrick Steinhardt
2024-05-23 15:58             ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5xv4wme6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dsimic@manjaro.org \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=ps@pks.im \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.