From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Michael Lohmann <mi.al.lohmann@gmail.com>,
git@vger.kernel.org, Wanja Henze <wanja.hentze@bevuta.com>
Subject: Re: [PATCH] builtin/revert.c: refactor using an enum for cmd-action
Date: Thu, 11 Jan 2024 11:37:37 -0800 [thread overview]
Message-ID: <xmqq5xzzhda6.fsf@gitster.g> (raw)
In-Reply-To: <1ed0e249-dab9-4cf3-9b76-c8797b97c9c5@gmail.com> (Phillip Wood's message of "Thu, 11 Jan 2024 16:57:26 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> I think ACTION_NONE was intended to covey that the user did not pass
> one of the OPT_CMDMODE() options like "--continue" as there isn't a
> "--start" option. I don't have a strong opinion between "_NONE" and
> "_START".
I agree with you why NONE is called as such. If "revert" does not
take "--start" (I do not remember offhand), I would think it would
be better to follow suit.
prev parent reply other threads:[~2024-01-11 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 8:04 [PATCH] builtin/revert.c: refactor using an enum for cmd-action Michael Lohmann
2024-01-11 16:57 ` Phillip Wood
2024-01-11 17:47 ` [PATCH v2] " Michael Lohmann
2024-01-11 19:50 ` Junio C Hamano
2024-01-11 20:06 ` [PATCH v3] " Michael Lohmann
2024-01-11 21:47 ` Junio C Hamano
2024-01-12 0:40 ` Junio C Hamano
2024-01-12 7:24 ` Jeff King
2024-01-12 18:13 ` Junio C Hamano
2024-01-12 19:33 ` Michael Lohmann
2024-01-11 19:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xzzhda6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mi.al.lohmann@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=wanja.hentze@bevuta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.