All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Altmanninger <aclopte@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Re* [PATCH] rerere-train: modernise a bit
Date: Sun, 27 Feb 2022 14:13:35 -0800	[thread overview]
Message-ID: <xmqq5yp03qls.fsf@gitster.g> (raw)
In-Reply-To: <20220227202328.7afrpuaujgwsnmcy@gmail.com> (Johannes Altmanninger's message of "Sun, 27 Feb 2022 21:23:28 +0100")

Johannes Altmanninger <aclopte@gmail.com> writes:

> The --no-pager fix would have prevented my confusion, which is an argument
> for placing it first.

I would rather squash them into one.  "--no-pager" alone would give
an apparent regression to people like you whose pager "corrected"
the output from the command, but with two changes squashed together,
we would not have to see any regression.

Thanks.


  reply	other threads:[~2022-02-27 22:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16  7:05 [PATCH] rerere-train: modernise a bit Junio C Hamano
2022-02-20 19:52 ` Derrick Stolee
2022-02-27 18:02 ` Johannes Altmanninger
2022-02-27 19:07   ` Re* " Junio C Hamano
2022-02-27 20:23     ` Johannes Altmanninger
2022-02-27 22:13       ` Junio C Hamano [this message]
2022-02-27 22:09 ` [PATCH v2] rerere-train: two fixes to the use of "git show -s" Junio C Hamano
2022-02-28  5:33   ` Johannes Altmanninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5yp03qls.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=aclopte@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.