From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Derrick Stolee <stolee@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: ds/sparse-checkout-requires-per-worktree-config
Date: Sat, 25 Dec 2021 14:20:20 -0800 [thread overview]
Message-ID: <xmqq5yrc5ntn.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BFiMy55mCMJSHk9PmKa8EUd-6mR5z5xM7J3P2dZBjRq5g@mail.gmail.com> (Elijah Newren's message of "Fri, 24 Dec 2021 18:49:59 -0800")
Elijah Newren <newren@gmail.com> writes:
> On Fri, Dec 24, 2021 at 6:11 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>> > * ds/sparse-checkout-requires-per-worktree-config (2021-12-21) 5 commits
>> > - sparse-checkout: use repo_config_set_worktree_gently()
>> > - config: add repo_config_set_worktree_gently()
>> > - worktree: add upgrade_to_worktree_config()
>> > - config: make some helpers repo-aware
>> > - setup: use a repository when upgrading format
>> >
>> > "git sparse-checkout" wants to work with per-worktree configration,
>> > but did not work well in a worktree attached to a bare repository.
>> >
>> > Expecting a redesign?
>> > cf. <CABPp-BG7nwsdEYrnfqhAbWU4ndJHcqGf6RS_6DzJittuNVLvoA@mail.gmail.com>
>> > source: <pull.1101.v2.git.1640114048.gitgitgadget@gmail.com>
>>
>> FWIW, this topic by itself passes its self test, but when queued
>> near the tip of 'seen', it seems to break t1091.
>>
>> For an example run that fails on win+VS test (8), see
>> https://github.com/git/git/runs/4629824103
>
> Unrelated to your comment, other than being about this same series:
>
> I think "redesign" is too strong a word here. I think the patches are
> a useful start...and might even represent the majority of the code
> needed; it's just that they are focusing too narrowly. core.worktree
> should also be handled, and I think we should include fixes at the
> `git worktree add` level, not just `git sparse-checkout {init,set}`.
Yup, the last one part is what I meant by "redesign".
next prev parent reply other threads:[~2021-12-25 22:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 23:42 What's cooking in git.git (Dec 2021, #05; Thu, 23) Junio C Hamano
2021-12-24 17:29 ` ab/make-dependency (was "What's cooking in git.git (Dec 2021, #05; Thu, 23)) Ævar Arnfjörð Bjarmason
2021-12-26 18:51 ` Junio C Hamano
2021-12-25 1:55 ` What's cooking in git.git (Dec 2021, #05; Thu, 23) Junio C Hamano
2021-12-25 2:49 ` ds/sparse-checkout-requires-per-worktree-config (Was: Re: What's cooking in git.git (Dec 2021, #05; Thu, 23)) Elijah Newren
2021-12-25 22:20 ` Junio C Hamano [this message]
2021-12-25 6:44 ` What's cooking in git.git (Dec 2021, #05; Thu, 23) Eric Sunshine
2021-12-25 12:07 ` Teng Long
2021-12-26 17:15 ` Ævar Arnfjörð Bjarmason
2021-12-27 7:09 ` Teng Long
2021-12-26 17:24 ` ab/only-single-progress-at-once (was: What's cooking in git.git (Dec 2021, #05; Thu, 23)) Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5yrc5ntn.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.