From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, David Turner <novalis@novalis.org>
Subject: Re: [PATCH 1/2] unwritable tests: assert exact error output
Date: Mon, 11 Oct 2021 13:50:52 -0700 [thread overview]
Message-ID: <xmqq5yu3b80j.fsf@gitster.g> (raw)
In-Reply-To: <patch-1.2-a5ef8ea47f4-20211009T133354Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sat, 9 Oct 2021 15:34:02 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> In preparation for fixing a regression where we started emitting some
> of these error messages twice, let's assert what the output from "git
> commit" and friends is now in the case of permission errors.
Usually we frown upon expecting an exact error message, but I guess
that the nature of the bug this series tries to address justifies
it.
> - test_must_fail git write-tree
> +
> + cat >expect <<-\EOF &&
> + error: insufficient permission for adding an object to repository database .git/objects
> + fatal: git-write-tree: error building trees
> + EOF
> + test_must_fail git write-tree 2>actual &&
> + test_cmp expect actual
> '
OK.
> test_expect_success POSIXPERM,SANITY 'commit should notice unwritable repository' '
> test_when_finished "chmod 775 .git/objects .git/objects/??" &&
> chmod a-w .git/objects .git/objects/?? &&
> - test_must_fail git commit -m second
> +
> + cat >expect <<-\EOF &&
> + error: insufficient permission for adding an object to repository database .git/objects
> + error: insufficient permission for adding an object to repository database .git/objects
> + error: Error building trees
> + EOF
This is odd. Shouldn't the test expect one message from write-tree
and be marked as expecting a failure until the bug gets fixed?
> + test_must_fail git commit -m second 2>actual &&
> + test_cmp expect actual
> '
prev parent reply other threads:[~2021-10-11 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 13:34 [PATCH 1/2] unwritable tests: assert exact error output Ævar Arnfjörð Bjarmason
2021-10-09 13:34 ` [PATCH 2/2] commit: fix duplication regression in permission " Ævar Arnfjörð Bjarmason
2021-10-11 20:56 ` Junio C Hamano
2021-10-12 14:30 ` [PATCH v2 0/2] " Ævar Arnfjörð Bjarmason
2021-10-12 14:30 ` [PATCH v2 1/2] unwritable tests: assert exact " Ævar Arnfjörð Bjarmason
2021-10-12 14:30 ` [PATCH v2 2/2] commit: fix duplication regression in permission " Ævar Arnfjörð Bjarmason
2021-10-11 20:50 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5yu3b80j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=novalis@novalis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.