All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Lénaïc Huard" <lenaic@lhuard.fr>
Cc: git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	lilinchao@oschina.cn
Subject: Re: [PATCH v2 0/1] maintenance: fix two memory leaks
Date: Tue, 11 May 2021 12:29:43 +0900	[thread overview]
Message-ID: <xmqq5yzqosm0.fsf@gitster.g> (raw)
In-Reply-To: <20210510195909.621534-1-lenaic@lhuard.fr> ("Lénaïc Huard"'s message of "Mon, 10 May 2021 21:59:08 +0200")

Lénaïc Huard <lenaic@lhuard.fr> writes:

> Hi!
>
> Thank you for the code review.
>
> I’ve moved the `strbuf_release(&line);` closer to the last point where
> `line` is used.
>
> And I’ve included Junio’s patch to address the missing
> `free(local_path)` when `hold_lock_file_for_update()<0`.
>
> Lénaïc Huard (1):
>   maintenance: fix two memory leaks
>
>  builtin/gc.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Thanks, will queue.

      parent reply	other threads:[~2021-05-11  3:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09 22:16 [PATCH] maintenance: fix two memory leaks Lénaïc Huard
2021-05-10  6:34 ` Junio C Hamano
2021-05-10  6:38 ` lilinchao
2021-05-10  7:11   ` Junio C Hamano
     [not found]   ` <0c04f7c2b15f11eb82baa4badb2c2b1178978@pobox.com>
2021-05-10  7:50     ` lilinchao
2021-05-10 19:59 ` [PATCH v2 0/1] " Lénaïc Huard
2021-05-10 19:59   ` [PATCH v2 1/1] " Lénaïc Huard
2021-05-11 15:13     ` Derrick Stolee
2021-05-11  3:29   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5yzqosm0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=lenaic@lhuard.fr \
    --cc=lilinchao@oschina.cn \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.