From: Junio C Hamano <gitster@pobox.com>
To: Armin Kunaschik <megabreit@googlemail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: syntax error in git-rebase while running t34* tests
Date: Tue, 10 May 2016 12:11:59 -0700 [thread overview]
Message-ID: <xmqq60ulpw1s.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CALR6jEiF9Ooi1f0O3KG0wYmN0KRWBQTNarXx79-wBD2E-8q2jA@mail.gmail.com> (Armin Kunaschik's message of "Tue, 10 May 2016 19:29:51 +0200")
Armin Kunaschik <megabreit@googlemail.com> writes:
> I fail to see why eval is really necessary here.
It is necessary to work correctly with any strategy option with $IFS
in it, I would think. The calling script "git-rebase" accumulates
--strategy-option values after passing each of them through
"rev-parse --sq-quote" for that reason.
which means that eval'ed string here:
> My quick and dirty hotfix is to place a
> test -n "$strategy_opts" &&
> in front of the eval.
> The tests run fine after this change.
>
> What do you think?
I do not see why "test -n &&" is necessary here, and would be very
hesitant to accept a change that nobody understands why it works.
next prev parent reply other threads:[~2016-05-10 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 17:29 syntax error in git-rebase while running t34* tests Armin Kunaschik
2016-05-10 19:11 ` Junio C Hamano [this message]
2016-05-10 20:47 ` Jeff King
2016-05-10 20:53 ` Junio C Hamano
2016-05-10 21:07 ` Jeff King
2016-05-11 13:28 ` Johannes Schindelin
2016-05-11 13:36 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60ulpw1s.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=megabreit@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.