All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Dmitry Vilkov <dmitry.a.vilkov@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] remote-curl: don't fall back to Basic auth if we haven't tried Negotiate
Date: Fri, 05 Feb 2016 13:52:23 -0800	[thread overview]
Message-ID: <xmqq60y2dduw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160205210623.GC7403@vauxhall.crustytoothpaste.net> (brian m. carlson's message of "Fri, 5 Feb 2016 21:06:24 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> On Fri, Feb 05, 2016 at 01:02:58PM -0800, Junio C Hamano wrote:
>> Hmph, so documenting that <emptyname>:<emptypassword>@<repository>
>> as a supported way might be an ugly-looking solution to the original
>> problem.  A less ugly-looking solution might be a boolean that can
>> be set per URL (we already have urlmatch-config infrastructure to
>> help us do so) to tell us to pass the empty credential to lubCurl,
>> bypassing the step to ask the user for password that we do not use.
>> 
>> The end-result of either of these solution would strictly be better
>> than the patch we discussed in that the end user will not have to
>> interact with the prompt at all, right?
>
> Yes, that's true.  I'll try to come up with a patch this weekend that
> implements that (maybe remote.forceAuth = true or somesuch).

Thanks.

I think the configuration should live inside http.* namespace, as
there are already things like http[.<url>].sslCert and friends.

I do not have a good suggestion on the name of the leaf-level
variable.  ForceAuth sounds as if you are forcing authentication
even when the other side does not require it, though.

  reply	other threads:[~2016-02-05 21:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02  9:11 [PATCH] remote-curl: don't fall back to Basic auth if we haven't tried Negotiate Dmitry Vilkov
2016-02-02 20:37 ` Junio C Hamano
2016-02-02 23:29   ` brian m. carlson
2016-02-05  9:18     ` Dmitry Vilkov
2016-02-05 17:54       ` Junio C Hamano
2016-02-05 20:58         ` brian m. carlson
2016-02-06 17:53         ` Daniel Stenberg
2016-02-05 20:46       ` brian m. carlson
2016-02-05 21:02         ` Junio C Hamano
2016-02-05 21:06           ` brian m. carlson
2016-02-05 21:52             ` Junio C Hamano [this message]
2016-02-08  9:11               ` Dmitry Vilkov
2016-02-15 18:44                 ` [PATCH] http: add option to try authentication without username brian m. carlson
2016-02-15 20:19                   ` Eric Sunshine
2016-02-15 20:29                     ` brian m. carlson
2016-02-15 20:34                       ` Jeff King
2016-02-15 20:36                         ` brian m. carlson
2016-02-15 21:39                           ` Junio C Hamano
2016-02-15 21:41                             ` brian m. carlson
2016-02-15 21:46                             ` Eric Sunshine
2016-02-15 21:51                               ` brian m. carlson
2016-02-20 14:35                 ` [PATCH] remote-curl: don't fall back to Basic auth if we haven't tried Negotiate Dmitry Vilkov
2016-02-20 15:23                   ` brian m. carlson
2016-02-20 21:38                   ` Junio C Hamano
2016-02-25 16:54                     ` Dmitry Vilkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq60y2dduw.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=dmitry.a.vilkov@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.