From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twopensource.com>
Cc: git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] do_compare_entry: use already-computed path
Date: Tue, 22 Dec 2015 10:51:41 -0800 [thread overview]
Message-ID: <xmqq60zqe2pu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1450758362.3892.7.camel@twopensource.com> (David Turner's message of "Mon, 21 Dec 2015 23:26:02 -0500")
David Turner <dturner@twopensource.com> writes:
> On Mon, 2015-12-21 at 15:34 -0800, Junio C Hamano wrote:
>> Great. Thanks, will queue w/o 1/2 (though I do not think it would
>> hurt).
>>
>> On Mon, Dec 21, 2015 at 3:33 PM, David Turner <
>> dturner@twopensource.com> wrote:
>> > On Mon, 2015-12-21 at 15:27 -0800, Junio C Hamano wrote:
>> > > Thanks. Does the number still stay at 25% improvement?
>> >
>> > Yes.
>
> BTW, that function, via ce_in_traverse_path, gets called about 40
> million times when switching (checking out) between master and a
> branch that's a few months old (and that contains relatively small
> changes from master-as-of-then. Our repo only has approximately a
> quarter -million files. This seems somewhat unreasonable to me,
> but I haven't really looked into what's going on. Do you happen
> to know why this is and whether it is likely to be a bug?
That does sound excessive; smells like somebody is being overly
cautious (i.e. a performance bug).
We might be seeing something similar to what e53e6b44 observed and
attempted to correct. I dunno.
prev parent reply other threads:[~2015-12-22 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 22:34 [PATCH v2 0/2] do_compare_entry: use already-computed path David Turner
2015-12-21 22:34 ` [PATCH v2 1/2] traverse_info: make mostly const David Turner
2015-12-21 23:15 ` David Turner
2015-12-21 22:34 ` [PATCH v2 2/2] do_compare_entry: use already-computed path David Turner
2016-01-05 19:40 ` David Turner
2015-12-21 23:27 ` [PATCH v2 0/2] " Junio C Hamano
2015-12-21 23:33 ` David Turner
[not found] ` <CAPc5daW4ru0j4Zd3ynnRcG8df7sZ9ZuVHu8mz2rxVonZpyE4Gw@mail.gmail.com>
2015-12-22 4:26 ` David Turner
2015-12-22 18:51 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60zqe2pu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.