From: Junio C Hamano <gitster@pobox.com>
To: Luke Diamand <luke@diamand.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv3 1/3] git-p4: add failing test for P4EDITOR handling
Date: Wed, 20 May 2015 12:54:31 -0700 [thread overview]
Message-ID: <xmqq617nnhxk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1432074198-13806-2-git-send-email-luke@diamand.org> (Luke Diamand's message of "Tue, 19 May 2015 23:23:16 +0100")
Luke Diamand <luke@diamand.org> writes:
> +
> +test_expect_failure 'EDITOR has options' '
> +# Check that the P4EDITOR argument can be given command-line
> +# options, which git-p4 will then pass through to the shell.
> +test_expect_success 'EDITOR has options' '
> + git p4 clone --dest="$git" //depot &&
Oops? I assume that the one before the comment should go and this
one is
test_expect_failure 'Editor with an option' '
or something.
> + test_when_finished cleanup_git &&
> + (
> + cd "$git" &&
> + echo change >file1 &&
> + git commit -m "change" file1 &&
> + P4EDITOR=": >\"$git/touched\" && test-chmtime +5" git p4 submit &&
> + test_path_is_file "$git/touched"
> + )
> +'
> +
> +test_expect_success 'kill p4d' '
> + kill_p4d
> +'
> +
> +test_done
next prev parent reply other threads:[~2015-05-20 19:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 6:40 git-p4: test t9820-git-p4-editor-handling.sh failing Luke Diamand
2015-05-19 15:44 ` Junio C Hamano
2015-05-19 22:23 ` [PATCHv3 0/3] git-p4: fix handling of multi-word P4EDITOR Luke Diamand
2015-05-19 22:23 ` [PATCHv3 1/3] git-p4: add failing test for P4EDITOR handling Luke Diamand
2015-05-20 19:54 ` Junio C Hamano [this message]
2015-05-20 20:56 ` Junio C Hamano
2015-05-20 21:43 ` Luke Diamand
2015-05-19 22:23 ` [PATCHv3 2/3] git-p4: fix handling of multi-word P4EDITOR Luke Diamand
2015-05-19 22:23 ` [PATCHv3 3/3] git-p4: tests: use test-chmtime in place of touch Luke Diamand
2015-05-19 22:36 ` Luke Diamand
2015-05-24 18:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq617nnhxk.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.