All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Johannes Sixt" <j6t@kdbg.org>, "René Scharfe" <l.s.r@web.de>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] run-command: introduce CHILD_PROCESS_INIT
Date: Mon, 18 Aug 2014 09:59:02 -0700	[thread overview]
Message-ID: <xmqq61hpybs9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140817084832.GL23808@peff.net> (Jeff King's message of "Sun, 17 Aug 2014 04:48:32 -0400")

Jeff King <peff@peff.net> writes:

> I'm a little worried, though, that use sites without initializers would
> be left behind. For example, git_proxy_connect uses xcalloc to allocate
> the child_process, which results in all-bits-zero. If we want to start
> caring about the initialization, we probably need to provide a
> child_process_init() function and use it consistently.

Thanks.  Perhaps I can expect a v2 from René?

  reply	other threads:[~2014-08-18 16:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-16 22:55 [PATCH] run-command: introduce CHILD_PROCESS_INIT René Scharfe
2014-08-17  7:12 ` Jeff King
2014-08-17  7:25   ` René Scharfe
2014-08-17  7:29     ` Jeff King
2014-08-17  7:46 ` Johannes Sixt
2014-08-17  8:48   ` Jeff King
2014-08-18 16:59     ` Junio C Hamano [this message]
2014-08-19 19:09       ` [PATCH v2 1/4] " René Scharfe
2014-08-19 19:10       ` [PATCH v2 2/4] run-command: introduce child_process_init() René Scharfe
2014-08-19 19:11       ` [PATCH v2 3/4] run-command: call run_command_v_opt_cd_env() instead of duplicating it René Scharfe
2014-08-19 19:11       ` [PATCH v2 4/4] run-command: inline prepare_run_command_v_opt() René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq61hpybs9.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.