From: Junio C Hamano <gitster@pobox.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
He Sun <sunheehnus@gmail.com>,
Faiz Kothari <faiz.off93@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] implemented strbuf_write_or_die()
Date: Tue, 04 Mar 2014 10:45:46 -0800 [thread overview]
Message-ID: <xmqq61ntls4l.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53159A81.4050905@alum.mit.edu> (Michael Haggerty's message of "Tue, 04 Mar 2014 10:18:57 +0100")
Michael Haggerty <mhagger@alum.mit.edu> writes:
> On 03/03/2014 07:31 PM, Junio C Hamano wrote:
>> That is a very good sign why this change is merely a code-churn and
>> not an improvement, isn't it? We know (and any strbuf user should
>> know) that ->buf and ->len are the ways to learn the pointer and the
>> length the strbuf holds.
> ...
> ... Writing strbufs comes up frequently and will hopefully increase in
> usage and I think it is a positive thing to encourage the use of strbufs
> by making them increasingly first-class citizens.
Yeah, I understand that. I suspect that the conclusion would have
been very different if we were a C++ project; most likely it would
be an excellent idea to add an often-used write_or_die() method to
the strbuf class. But we are writing C.
> Faiz, this is the way things go on the Git mailing list. It would be
> boring if everybody agreed all the time :-)
Surely, and thanks ;-)
next prev parent reply other threads:[~2014-03-04 18:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 11:21 [PATCH] implemented strbuf_write_or_die() Faiz Kothari
2014-03-01 12:51 ` He Sun
2014-03-01 13:29 ` Faiz Kothari
2014-03-01 22:33 ` Michael Haggerty
2014-03-02 0:18 ` [PATCH v2] " Faiz Kothari
2014-03-02 2:47 ` Eric Sunshine
2014-03-02 2:55 ` Eric Sunshine
2014-03-02 7:34 ` [PATCH v3 1/2] Introduce strbuf_write_or_die() Faiz Kothari
2014-03-02 7:34 ` [PATCH v3 2/2] use strbuf_write_or_die() Faiz Kothari
2014-03-02 22:04 ` Eric Sunshine
2014-03-02 20:05 ` [PATCH v3 1/2] Introduce strbuf_write_or_die() Eric Sunshine
2014-03-02 3:08 ` [PATCH] implemented strbuf_write_or_die() Eric Sunshine
2014-03-03 18:31 ` Junio C Hamano
[not found] ` <CAFbjVckhU7NHzLjqPo5WkoBwVLrOLg=CS6mHSKkQstUxB31_eA@mail.gmail.com>
2014-03-03 18:48 ` Fwd: " Faiz Kothari
2014-03-03 19:46 ` Eric Sunshine
2014-03-03 19:51 ` David Kastrup
2014-03-03 20:35 ` Junio C Hamano
2014-03-03 21:29 ` Eric Sunshine
2014-03-04 9:18 ` Michael Haggerty
2014-03-04 17:01 ` Faiz Kothari
2014-03-04 18:45 ` Junio C Hamano [this message]
2014-03-01 21:34 ` Johannes Sixt
2014-03-03 18:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61ntls4l.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=faiz.off93@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=sunheehnus@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.