All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Antoni Borowski <antekborowski11@gmail.com>
Cc: peff@peff.net,  git@vger.kernel.org,  jpoimboe@kernel.org
Subject: Re: [Microproject v2] describe: do not translate --debug output
Date: Fri, 06 Nov 2026 18:23:57 -0800	[thread overview]
Message-ID: <xmqq7bipbcqq.fsf@gitster.g> (raw)
In-Reply-To: <20261016185418.162998-1-antekborowski11@gmail.com> (Antoni Borowski's message of "Fri, 16 Oct 2026 20:54:18 +0200")

Antoni Borowski <antekborowski11@gmail.com> writes:

> The --debug flag is aimed at developers debugging describe's search
> strategy, not at end users. Translating this output makes it harder
> to grep for known strings, compare logs across locales, or paste
> output into upstream bug reports written in English — all things
> developers routinely need to do.
>
> transport-helper.c already follows this convention: its "Debug: ..."
> messages are plain C strings with no gettext wrapper.
>
> Drop the _() wrapper from describe_commit()'s and describe()'s
> debug-only fprintf() calls accordingly, and prefix them with
> "Debug: " to match transport-helper.c's style.
>
> Signed-off-by: Antoni Borowski <antekborowski11@gmail.com>
> ---
>  builtin/describe.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

OK, looking good.

Let's mark the topic as ready for 'next'.

> -		fprintf(stderr, _("No exact match on refs or tags, searching to describe\n"));
> +		fprintf(stderr, "Debug: No exact match on refs or tags, searching to describe\n");

Shame we do not have debugf() macro ;-)


  reply	other threads:[~2026-11-07  2:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 20:43 [Microproject] describe: pluralize tag/commit count messages Antoni Borowski
2026-10-14  9:29 ` Jeff King
2026-10-14 17:36   ` Junio C Hamano
2026-10-16 17:18     ` [Microproject] describe: do not translate --debug output Antoni Borowski
2026-10-16 18:35       ` Junio C Hamano
2026-10-16 18:54         ` [Microproject v2] " Antoni Borowski
2026-11-07  2:23           ` Junio C Hamano [this message]
2026-11-07  4:56           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7bipbcqq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=antekborowski11@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.