From: Junio C Hamano <gitster@pobox.com>
To: Igor Wiedler <iwiedler@gitlab.com>
Cc: git@vger.kernel.org, ps@pks.im, jltobler@gmail.com
Subject: Re: [PATCH v2 2/2] odb: ignore refs of shallow and grafted alternates
Date: Sat, 17 Oct 2026 18:19:59 -0700 [thread overview]
Message-ID: <xmqq7bjfby9s.fsf@gitster.g> (raw)
In-Reply-To: <20261014181134.56220-3-iwiedler@gitlab.com> (Igor Wiedler's message of "Wed, 14 Oct 2026 20:11:34 +0200")
Igor Wiedler <iwiedler@gitlab.com> writes:
> diff --git a/t/t5618-alternate-refs.sh b/t/t5618-alternate-refs.sh
> index 4cc39af0f0..9c3862709a 100755
> --- a/t/t5618-alternate-refs.sh
> +++ b/t/t5618-alternate-refs.sh
> @@ -70,4 +70,17 @@ test_expect_success 'connectivity check of a deepening fetch excludes alternate
> --alternate-refs --quiet <deepen.trace
> '
>
> +test_expect_success 'refs of a shallow alternate are ignored' '
> + git clone --depth=1 "file://$TRASH_DIRECTORY" "$TRASH_DIRECTORY/shallow" &&
> + test_commit -C "$TRASH_DIRECTORY/shallow" shallow-only &&
> + git -C "$TRASH_DIRECTORY/shallow" rev-parse HEAD >shallow-tip &&
> + cp .git/objects/info/alternates alternates.bak &&
> + test_when_finished "mv alternates.bak .git/objects/info/alternates" &&
> + echo "$TRASH_DIRECTORY/shallow/.git/objects" >>.git/objects/info/alternates &&
> + git cat-file -e $(cat shallow-tip) &&
> + git rev-list --remotes=origin >expect &&
> + git rev-list --alternate-refs >actual &&
> + test_cmp expect actual
> +'
This seems to break CI only on Windows
https://github.com/git/git/actions/runs/39084117165/job/117547610467#step:5:279
https://github.com/git/git/actions/runs/39084117165/job/117547743280#step:6:272
I'll eject the topic from 'seen' for now.
Thanks.
prev parent reply other threads:[~2026-10-18 1:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 10:35 [PATCH] connected: do not walk alternate refs in deepening fetches Igor Wiedler
2026-10-14 12:25 ` Patrick Steinhardt
2026-10-14 16:55 ` Junio C Hamano
2026-10-15 6:41 ` Jeff King
2026-10-14 17:02 ` Justin Tobler
2026-10-14 18:11 ` [PATCH v2 0/2] connected: fix the connectivity check with alternates " Igor Wiedler
2026-10-14 19:23 ` Junio C Hamano
2026-10-14 18:11 ` [PATCH v2 1/2] connected: negate alternate refs in deepening fetches too Igor Wiedler
2026-10-14 18:11 ` [PATCH v2 2/2] odb: ignore refs of shallow and grafted alternates Igor Wiedler
2026-10-15 6:57 ` Jeff King
2026-10-15 17:25 ` Junio C Hamano
2026-10-16 3:14 ` Jeff King
2026-10-18 1:19 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7bjfby9s.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=iwiedler@gitlab.com \
--cc=jltobler@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.