All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: phillip.wood@dunelm.org.uk,
	"Abraham Samuel Adekunle" <abrahamadekunle50@gmail.com>,
	git@vger.kernel.org, "Patrick Steinhardt" <ps@pks.im>,
	"SZEDER Gábor" <szeder.dev@gmail.com>,
	"Christian Couder" <christian.couder@gmail.com>,
	"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Subject: Re: [GSoC PATCH v6] add -p: show user's hunk decision when selecting hunks
Date: Wed, 07 Jan 2026 09:13:59 +0900	[thread overview]
Message-ID: <xmqq7btujn3s.fsf@gitster.g> (raw)
In-Reply-To: <ADCF604A-A3F1-48B9-B29E-777CE7026EAA@gmail.com> (Ben Knoble's message of "Tue, 6 Jan 2026 14:01:31 -0500")

Ben Knoble <ben.knoble@gmail.com> writes:

>> I like the idea of telling the user if the hunk is currently
>> selected but say "(previous decision: use)" makes the prompt
>> rather long (some of the prompts in the tests below are 80
>> characters long). I wonder if we can find a more compact
>> notation. "(currently selected)" is a bit shorter and takes us
>> under 80 characters but is still longer than I'd like - maybe
>> someone reading this will have a better suggestion.
>
> I haven’t looked carefully, so apologies if this is nonsense.
>
> What if the marker of current state were on a separate line before
> the prompt? That would allow more room, right?

Vertical screen real estate is also a limited resource.  Also, while
it is good if we let users know what the current selection status
is, I personally do not think the benefit outweighs the downside of
cluttering the prompt unless it is kept to the minimum.  So I very
much appreciate that Phillip raised this point.

Thanks.

  reply	other threads:[~2026-01-07  0:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-30 15:06 [PATCH] add -p: show hunk selection state when selecting hunks Abraham Samuel Adekunle
2025-11-30 18:32 ` Junio C Hamano
2025-12-01 10:01   ` Abraham Samuel Adekunle
2026-01-01 21:04 ` [GSoC PATCH v2] add -p: show user's hunk decision " Abraham Samuel Adekunle
2026-01-01 22:54   ` Junio C Hamano
2026-01-02  7:20     ` Samuel Abraham
2026-01-02 18:51   ` [GSoC PATCH v3] " Abraham Samuel Adekunle
2026-01-04  6:03     ` Junio C Hamano
2026-01-04 10:36       ` Samuel Abraham
2026-01-04 11:02     ` [GSoC PATCH v4] " Abraham Samuel Adekunle
2026-01-05 19:35       ` SZEDER Gábor
2026-01-05 21:52         ` Samuel Abraham
2026-01-06 11:05       ` [GSoC PATCH v5] " Abraham Samuel Adekunle
2026-01-06 11:08         ` Kristoffer Haugsbakk
2026-01-06 11:46           ` Samuel Abraham
2026-01-06 12:01         ` [GSoC PATCH v6] " Abraham Samuel Adekunle
2026-01-06 16:10           ` Phillip Wood
2026-01-06 19:01             ` Ben Knoble
2026-01-07  0:13               ` Junio C Hamano [this message]
2026-01-06 22:02             ` Samuel Abraham
2026-01-06 22:19               ` Samuel Abraham
2026-01-07  8:49                 ` Samuel Abraham
2026-01-08 15:07           ` [GSoC PATCH v7] " Abraham Samuel Adekunle
2026-01-11  3:57             ` Junio C Hamano
2026-01-11 11:04               ` Samuel Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7btujn3s.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=abrahamadekunle50@gmail.com \
    --cc=ben.knoble@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.