From: Junio C Hamano <gitster@pobox.com>
To: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gpg-interface: trim only CR characters that precede LF
Date: Thu, 16 Oct 2025 13:50:45 -0700 [thread overview]
Message-ID: <xmqq7bwu3716.fsf@gitster.g> (raw)
In-Reply-To: <CAFpMFfBe7+pMUL8aaDkGkPUaE9RhCW25OJhJy69EcukgSFn9+A@mail.gmail.com> (Okhuomon Ajayi's message of "Thu, 16 Oct 2025 20:38:11 +0100")
Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:
> Hi Junio,
> Haha, I smiled at your “teh” comment — I myself often make teh same typo
> Thanks a lot for catching the typo and for the detailed feedback on
> style and indentation.
> I’ll fix the tab/space mix, shorten the long line, and use your
> suggested comment wording in the next revision
I was hinting that the new function name is less than optimal, which
may not have been conveyed very well X-<.
>> > -static void remove_cr_after(struct strbuf *buffer, size_t offset)
>> > +static void trim_cr_before_lf(struct strbuf *buffer, size_t offset)
>>
>> In other words, this normalizes crlf to lf line ending.
next prev parent reply other threads:[~2025-10-16 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 18:44 [PATCH] gpg-interface: trim only CR characters that precede LF Okhuomon Ajayi
2025-10-16 18:52 ` Junio C Hamano
2025-10-16 19:38 ` Okhuomon Ajayi
2025-10-16 20:50 ` Junio C Hamano [this message]
2025-10-16 20:53 ` Kristoffer Haugsbakk
2025-10-16 21:01 ` Okhuomon Ajayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7bwu3716.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=okhuomonajayi54@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.