From: Junio C Hamano <gitster@pobox.com>
To: "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Victoria Dye <vdye@github.com>,
Neeraj Singh <neerajsi@microsoft.com>,
Patrick Steinhardt <ps@pks.im>,
Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH v2 3/3] p7821: fix instructions for testing with threads
Date: Mon, 14 Apr 2025 14:48:29 -0700 [thread overview]
Message-ID: <xmqq7c3mpg7m.fsf@gitster.g> (raw)
In-Reply-To: <abd146b7c2a62aaef5c22269cff155387f33fe32.1744481732.git.gitgitgadget@gmail.com> (Philippe Blain via GitGitGadget's message of "Sat, 12 Apr 2025 18:15:32 +0000")
"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Philippe Blain <levraiphilippeblain@gmail.com>
>
> In 7b31b55db1 (perf: amend the grep tests to test grep.threads,
> 2017-12-29), p7821 was tweaked to test the performance of 'git grep'
> under different number of threads. These tests are run if
> GIT_PERF_GREP_THREADS is set to a list of thread numbers, but the
> comment at the top of the file instead mentions GIT_PERF_7821_THREADS.
> Fix the comment.
>
> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
> ---
> t/perf/p7821-grep-engines-fixed.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks.
next prev parent reply other threads:[~2025-04-14 21:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 17:07 [PATCH 0/2] Two perf test fixes Philippe Blain via GitGitGadget
2025-03-28 17:07 ` [PATCH 1/2] p7821: fix test_perf invocation for prereqs Philippe Blain via GitGitGadget
2025-03-31 7:27 ` Patrick Steinhardt
2025-04-13 19:00 ` Philippe Blain
2025-03-28 17:07 ` [PATCH 2/2] p9210: fix 'scalar clone' when running from a detached HEAD Philippe Blain via GitGitGadget
2025-03-31 7:27 ` Patrick Steinhardt
2025-04-12 18:15 ` [PATCH v2 0/3] Two perf test fixes Philippe Blain via GitGitGadget
2025-04-12 18:15 ` [PATCH v2 1/3] p7821: fix test_perf invocation for prereqs Philippe Blain via GitGitGadget
2025-04-12 18:15 ` [PATCH v2 2/3] p9210: fix 'scalar clone' when running from a detached HEAD Philippe Blain via GitGitGadget
2025-04-12 18:15 ` [PATCH v2 3/3] p7821: fix instructions for testing with threads Philippe Blain via GitGitGadget
2025-04-14 21:48 ` Junio C Hamano [this message]
2025-04-13 2:50 ` [PATCH v2 0/3] Two perf test fixes Philippe Blain
2025-04-14 16:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7c3mpg7m.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=neerajsi@microsoft.com \
--cc=ps@pks.im \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.