All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Olga Pilipenco" <olga.pilipenco@shopify.com>,
	"Olga Pilipenco via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Patrick Steinhardt" <ps@pks.im>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH v2] worktree: detect from secondary worktree if main worktree is bare
Date: Wed, 29 Jan 2025 09:08:26 -0800	[thread overview]
Message-ID: <xmqq7c6dk0ol.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cSdbjzTmsBOmFnMxzYLGrUzY46=mkW9S+si2KxLhS623Q@mail.gmail.com> (Eric Sunshine's message of "Wed, 29 Jan 2025 08:41:54 -0500")

Eric Sunshine <sunshine@sunshineco.com> writes:

>> Wow, your explanation is so much better than mine.Thank you for
>> “translating" it for the world :) I’m still trying to get used to
>> the terminology used in this codebase.  I’ll steal your description
>> for sure (if you don’t mind).
>
> You are more than welcome to use the proposed commit message rewrite.
>
> (If you want to acknowledge assistance rendered, a Helped-by: trailer,
> preceding your Signed-off-by:, is the way to do so. Or not. It's up to
> you.)
> ...

> Agreed about the is-bare checks -- and indeed the entire Git startup
> sequence -- being difficult to digest, however...
> ...

Thanks for an easy-to-read review (and thanks OP for working on it,
of course).


  reply	other threads:[~2025-01-29 17:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15  6:52 [PATCH] worktree: detect from secondary worktree if main worktree is bare Olga Pilipenco via GitGitGadget
2025-01-16 21:35 ` [PATCH v2] " Olga Pilipenco via GitGitGadget
2025-01-19 22:30   ` Eric Sunshine
2025-01-28 21:44     ` Olga Pilipenco
2025-01-29 13:41       ` Eric Sunshine
2025-01-29 17:08         ` Junio C Hamano [this message]
     [not found]         ` <F15C12AB-2238-4553-AFA5-18277B18CE5A@shopify.com>
2025-01-30 14:32           ` Eric Sunshine
2025-01-30 14:44             ` Eric Sunshine
2025-01-31  7:05               ` Olga Pilipenco
2025-01-31 13:28                 ` Eric Sunshine
2025-01-31 18:08   ` [PATCH v3] " Olga Pilipenco via GitGitGadget
2025-01-31 19:19     ` Junio C Hamano
2025-01-31 19:26       ` Junio C Hamano
2025-01-31 20:11         ` Olga Pilipenco
2025-01-31 20:20           ` Junio C Hamano
2025-02-04 19:03             ` Olga Pilipenco
2025-02-04 19:43               ` Junio C Hamano
2025-02-04 20:33                 ` Olga Pilipenco
2025-02-05  6:30     ` [PATCH v4] " Olga Pilipenco via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7c6dk0ol.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=l.s.r@web.de \
    --cc=olga.pilipenco@shopify.com \
    --cc=ps@pks.im \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.