From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 5/6] oddballs: send usage() help text to standard output
Date: Thu, 16 Jan 2025 09:24:01 -0800 [thread overview]
Message-ID: <xmqq7c6uu0y6.fsf@gitster.g> (raw)
In-Reply-To: <20250116104219.GC773990@coredump.intra.peff.net> (Jeff King's message of "Thu, 16 Jan 2025 05:42:19 -0500")
Jeff King <peff@peff.net> writes:
>> .... Some
>> just do not treat "-h" any specially, and let it take the same error
>> code paths as a parameter error.
> ...
>> + show_usage_and_exit_if_asked(argc, argv, var_usage);
>> if (argc != 2)
>> usage(var_usage);
>
> Hmm, what's going on in this one? It does not check "-h" at all.
Yes, this is the one that let the usual error code paths to treat it
as a mere parameter error.
next prev parent reply other threads:[~2025-01-16 17:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 1:25 [PATCH v3 0/6] Send help text from "git cmd -h" to stdout Junio C Hamano
2025-01-16 1:25 ` [PATCH v3 1/6] parse-options: add show_usage_help_and_exit_if_asked() Junio C Hamano
2025-01-16 1:25 ` [PATCH v3 2/6] t0012: optionally check that "-h" output goes to stdout Junio C Hamano
2025-01-16 1:25 ` [PATCH v3 3/6] builtins: send usage_with_options() help text to standard output Junio C Hamano
2025-01-16 1:25 ` [PATCH v3 4/6] usage: add show_usage_and_exit_if_asked() Junio C Hamano
2025-01-16 10:36 ` Jeff King
2025-01-16 10:44 ` Jeff King
2025-01-16 17:22 ` Junio C Hamano
2025-01-16 21:54 ` Jeff King
2025-01-16 22:26 ` Junio C Hamano
2025-01-16 1:25 ` [PATCH v3 5/6] oddballs: send usage() help text to standard output Junio C Hamano
2025-01-16 10:42 ` Jeff King
2025-01-16 17:24 ` Junio C Hamano [this message]
2025-01-16 1:25 ` [PATCH v3 6/6] builtin: " Junio C Hamano
2025-01-16 17:30 ` Junio C Hamano
2025-01-16 20:37 ` Junio C Hamano
2025-01-16 10:46 ` [PATCH v3 0/6] Send help text from "git cmd -h" to stdout Jeff King
2025-01-16 17:28 ` Junio C Hamano
2025-01-16 21:35 ` [PATCH v4 " Junio C Hamano
2025-01-16 21:35 ` [PATCH v4 1/6] t0012: optionally check that "-h" output goes " Junio C Hamano
2025-01-16 21:35 ` [PATCH v4 2/6] parse-options: add show_usage_with_options_if_asked() Junio C Hamano
2025-01-16 21:35 ` [PATCH v4 3/6] usage: add show_usage_if_asked() Junio C Hamano
2025-01-16 23:00 ` Junio C Hamano
2025-01-17 11:41 ` Jeff King
2025-01-16 21:35 ` [PATCH v4 4/6] builtins: send usage_with_options() help text to standard output Junio C Hamano
2025-01-16 21:35 ` [PATCH v4 5/6] oddballs: send usage() " Junio C Hamano
2025-01-16 21:35 ` [PATCH v4 6/6] builtin: " Junio C Hamano
2025-01-17 11:42 ` Jeff King
2025-01-17 19:46 ` Junio C Hamano
2025-01-17 21:31 ` [PATCH v5 0/6] Send help text from "git cmd -h" to stdout Junio C Hamano
2025-01-17 21:31 ` [PATCH v5 1/6] t0012: optionally check that "-h" output goes " Junio C Hamano
2025-01-17 21:31 ` [PATCH v5 2/6] parse-options: add show_usage_with_options_if_asked() Junio C Hamano
2025-01-17 21:31 ` [PATCH v5 3/6] usage: add show_usage_if_asked() Junio C Hamano
2025-01-17 21:31 ` [PATCH v5 4/6] builtins: send usage_with_options() help text to standard output Junio C Hamano
2025-01-17 21:31 ` [PATCH v5 5/6] oddballs: send usage() " Junio C Hamano
2025-01-17 21:31 ` [PATCH v5 6/6] builtin: " Junio C Hamano
2025-01-18 11:42 ` [PATCH v5 0/6] Send help text from "git cmd -h" to stdout Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7c6uu0y6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.