From: Junio C Hamano <gitster@pobox.com>
To: <git@vger.kernel.org>
Cc: <rsbecker@nexbridge.com>
Subject: [PATCH] t0018: remove leftover debugging cruft
Date: Thu, 01 Aug 2024 11:51:12 -0700 [thread overview]
Message-ID: <xmqq7cd0ulen.fsf_-_@gitster.g> (raw)
In-Reply-To: <xmqqbk2cum5o.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 01 Aug 2024 11:34:59 -0700")
The actual file is copied out to /tmp, presumably so that the tester
can inspect it after the test is done, which may have been a useful
debugging aid.
But in the final shape of the test suite, such a code should not
exist. We cannot even assume that we are allowed to write into /tmp
(our TMPDIR may not even be pointing at it) or read from it for that
matter.
Noticed-by: Randall S. Becker <rsbecker@nexbridge.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
t/t0018-advice.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/t/t0018-advice.sh b/t/t0018-advice.sh
index b02448ea16..040a08be07 100755
--- a/t/t0018-advice.sh
+++ b/t/t0018-advice.sh
@@ -93,7 +93,6 @@ EOF
>README &&
GIT_ADVICE=true git status
) >actual &&
- cat actual > /tmp/actual &&
test_cmp expect actual
'
--
2.46.0-179-g92bab5172e
next prev parent reply other threads:[~2024-08-01 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 18:15 [Bug] Temp file use in t0018.6 rsbecker
2024-08-01 18:34 ` Junio C Hamano
2024-08-01 18:51 ` Junio C Hamano [this message]
2024-08-01 18:53 ` [PATCH] t0018: remove leftover debugging cruft rsbecker
2024-08-01 18:51 ` [Bug] Temp file use in t0018.6 rsbecker
2024-08-02 3:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7cd0ulen.fsf_-_@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.