All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Linus Arver <linusa@google.com>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>,
	 Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] git: extend --no-lazy-fetch to work across subprocesses
Date: Fri, 16 Feb 2024 15:01:48 -0800	[thread overview]
Message-ID: <xmqq7cj4ggir.fsf@gitster.g> (raw)
In-Reply-To: <owlyh6i882k4.fsf@fine.c.googlers.com> (Linus Arver's message of "Fri, 16 Feb 2024 14:30:35 -0800")

Linus Arver <linusa@google.com> writes:

> FWIW, I see some typos. Otherwise this patch along with your "git:
> document GIT_NO_REPLACE_OBJECTS environment variable" one both LGTM for
> wording/readability. I must defer to Peff and others for "is this patch
> actually doing the right thing?" ;).
>
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Modeling after how the `--no-replace-objects` option is made usable
>> across subprocess spawning (e.g., cURL based remote helpers are
>> spawned as a separate process while running "git fetch"), allow the
>> `--no-lazy-fetch` option to be passed across process boundary.
>
> s/boundary/boundaries

Right; thanks.

>
>> Do not model how the value of GIT_NO_REPLACE_OBJECTS environment
>> variable is ignored, though.  Just use the usual git_env_bool() to
>> allow "export GIT_NO_LAZY_FETCH=0" and "unset GIT_NO_LAZY_FETCH"
>> to be equivalents.
>
> s/equivalents/equivalent

I meant to say that these two are "equivalents" (noun, plural).

I can rephrase to

	Just use git_env_bool() to make "export GIT_NO_LAZY_FETCH=0"
	an equivalent to "unset GIT_NO_LAZY_FETCH".

though, of course.

  reply	other threads:[~2024-02-16 23:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 23:17 [PATCH] git: --no-lazy-fetch option Junio C Hamano
2024-02-13 20:23 ` Linus Arver
2024-02-13 20:37   ` Linus Arver
2024-02-13 20:49     ` Junio C Hamano
2024-02-15  5:30 ` Jeff King
2024-02-15 17:04   ` Junio C Hamano
2024-02-16 17:22     ` Junio C Hamano
2024-02-16 21:09       ` [PATCH] git: extend --no-lazy-fetch to work across subprocesses Junio C Hamano
2024-02-16 22:30         ` Linus Arver
2024-02-16 23:01           ` Junio C Hamano [this message]
2024-02-16 23:12             ` Linus Arver
2024-02-17  5:40         ` Jeff King
2024-02-27  6:04           ` Junio C Hamano
2024-02-27  7:49             ` Jeff King
2024-02-27 16:48               ` Junio C Hamano
2024-03-07  9:56                 ` Jeff King
2024-03-07 20:33                   ` Junio C Hamano
2024-02-17  5:29       ` [PATCH] git: --no-lazy-fetch option Jeff King
2024-03-09  1:57         ` Linus Arver
2024-02-15 20:59   ` Linus Arver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7cj4ggir.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=linusa@google.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.