From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Jiang Xin <worldhello.net@gmail.com>,
Git List <git@vger.kernel.org>,
Jiang Xin <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH 2/2] fetch: no redundant error message for atomic fetch
Date: Tue, 24 Oct 2023 11:16:53 -0700 [thread overview]
Message-ID: <xmqq7cnb51ii.fsf@gitster.g> (raw)
In-Reply-To: <ZTZF3AbNNuGpy38l@tanuki> (Patrick Steinhardt's message of "Mon, 23 Oct 2023 12:07:24 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> With that reasoning we could get rid of the error handling of abort
> completely as it's known not to fail. But only because it does not fail
> right now doesn't mean that it won't in the future, as the infra for it
> to fail is all in place. And in case it ever does the current code will
> run into the bug I described.
>
> So in my opinion, we should either refactor the code to clarify that
> this cannot fail indeed. Or do the right thing and handle the error case
> correctly, which right now we don't.
Sounds reasonable. Thanks for a good review.
next prev parent reply other threads:[~2023-10-24 18:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 14:34 [PATCH 1/2] t5574: test porcelain output of atomic fetch Jiang Xin
2023-10-19 14:34 ` [PATCH 2/2] fetch: no redundant error message for " Jiang Xin
2023-10-23 8:27 ` Patrick Steinhardt
2023-10-23 9:16 ` Jiang Xin
2023-10-23 10:07 ` Patrick Steinhardt
2023-10-23 23:20 ` Jiang Xin
2023-10-25 8:21 ` Patrick Steinhardt
2023-10-24 18:16 ` Junio C Hamano [this message]
2023-12-14 12:33 ` [PATCH v2 0/2] jx/fetch-atomic-error-message-fix Jiang Xin
2023-12-14 12:33 ` [PATCH v2 1/2] t5574: test porcelain output of atomic fetch Jiang Xin
2023-12-15 9:56 ` Patrick Steinhardt
2023-12-15 11:16 ` Jiang Xin
2023-12-15 16:47 ` Junio C Hamano
2023-12-14 12:33 ` [PATCH v2 2/2] fetch: no redundant error message for " Jiang Xin
2023-12-15 9:56 ` Patrick Steinhardt
2023-12-17 14:11 ` [PATCH v3 0/2] fix fetch atomic error message Jiang Xin
2023-12-17 14:11 ` [PATCH v3 1/2] t5574: test porcelain output of atomic fetch Jiang Xin
2023-12-17 14:11 ` [PATCH v3 2/2] fetch: no redundant error message for " Jiang Xin
2023-12-18 8:14 ` [PATCH v3 0/2] fix fetch atomic error message Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7cnb51ii.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=worldhello.net@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.