From: Junio C Hamano <gitster@pobox.com>
To: "謝致邦 (XIE Zhibang) via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "謝致邦 (XIE Zhibang)" <Yeking@Red54.com>
Subject: Re: [PATCH] doc: correct the 50 characters soft limit
Date: Thu, 28 Sep 2023 07:10:18 -0700 [thread overview]
Message-ID: <xmqq7coal779.fsf@gitster.g> (raw)
In-Reply-To: <pull.1580.git.git.1695895155985.gitgitgadget@gmail.com> ("謝致邦 (XIE Zhibang) via GitGitGadget"'s message of "Thu, 28 Sep 2023 09:59:15 +0000")
"謝致邦 (XIE Zhibang) via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> The soft limit of the first line of the commit message should be
> "no more than 50 characters" or "50 characters or less", but not
> "less than 50 character".
The limit being "soft", I highly doubt that anybody would wonder if
a title that is exactly 50 columns wide is or is not acceptable.
The updated one is more grammatically correct than the original, so
the patch is not without merit, though ;-)
Thanks.
> ...
> Though not required, it's a good idea to begin the commit message
> -with a single short (less than 50 character) line summarizing the
> +with a single short (no more than 50 characters) line summarizing the
> change, followed by a blank line and then a more thorough description.
> The text up to the first blank line in a commit message is treated
> as the commit title, and that title is used throughout Git.
>
> base-commit: bcb6cae2966cc407ca1afc77413b3ef11103c175
prev parent reply other threads:[~2023-09-28 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 9:59 [PATCH] doc: correct the 50 characters soft limit 謝致邦 (XIE Zhibang) via GitGitGadget
2023-09-28 14:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7coal779.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Yeking@Red54.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.