From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Emir SARI <emir_sari@icloud.com>, git@vger.kernel.org
Subject: Re: Feature Request - Better i18n support
Date: Thu, 09 Mar 2023 14:35:57 -0800 [thread overview]
Message-ID: <xmqq7cvp8sdu.fsf@gitster.g> (raw)
In-Reply-To: <ZApdaAMrkmFcxarq@tapette.crustytoothpaste.net> (brian m. carlson's message of "Thu, 9 Mar 2023 22:27:52 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> More specifically, I think it could be fixed for progress output, but
> there are a few places in diff output where it couldn't because it might
> be parsed. Would you be willing to try a patch for this? I think the
> code you're probably thinking about is in progress.c (search for "%%"),
> but there might be other places you have in mind as well.
Ah, my earlier grep missed this, as it tried only to catch [fdi]%%
and the progress thing uses "%u%%" like so:
if (percent != progress->last_percent || progress_update) {
progress->last_percent = percent;
strbuf_reset(counters_sb);
strbuf_addf(counters_sb,
"%3u%% (%"PRIuMAX"/%"PRIuMAX")%s", percent,
(uintmax_t)n, (uintmax_t)progress->total,
tp);
show_update = 1;
}
With the PRIuMAX thing, it won't be as simple as enclosing the
entire format string inside _(), though.
Thanks.
next prev parent reply other threads:[~2023-03-09 22:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:56 Feature Request - Better i18n support Emir SARI
2023-03-09 22:16 ` Junio C Hamano
2023-03-09 23:12 ` Emir SARI
2023-03-09 22:27 ` brian m. carlson
2023-03-09 22:35 ` Junio C Hamano [this message]
2023-03-09 22:41 ` brian m. carlson
2023-05-10 2:50 ` Emir SARI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7cvp8sdu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=emir_sari@icloud.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.