From: Junio C Hamano <gitster@pobox.com>
To: "Moritz Baumann via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Tao Klerks <tao@klerks.biz>,
"Baumann, Moritz" <moritz.baumann@sap.com>
Subject: Re: [PATCH v2] git-p4: fix CR LF handling for utf16 files
Date: Wed, 20 Jul 2022 11:42:37 -0700 [thread overview]
Message-ID: <xmqq7d4739sy.fsf@gitster.g> (raw)
In-Reply-To: <pull.1294.v2.git.git.1658341065221.gitgitgadget@gmail.com> (Moritz Baumann via GitGitGadget's message of "Wed, 20 Jul 2022 18:17:45 +0000")
"Moritz Baumann via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Moritz Baumann <moritz.baumann@sap.com>
>
> Perforce silently replaces LF with CR LF for "utf16" files if the client
> is a native Windows client. Since git's autocrlf logic does not undo
> this transformation for UTF-16 encoded files, git-p4 replaces CR LF with
> LF during the sync if the file type "utf16" is detected and the Perforce
> client platform indicates that this conversion is performed.
>
> Windows only runs on little-endian architectures, therefore the encoding
> of the byte stream received from the Perforce client is UTF-16-LE and
> the relevant byte sequence is 0D 00 0A 00.
>
> Signed-off-by: Moritz Baumann <moritz.baumann@sap.com>
> ---
Will queue. Thanks.
prev parent reply other threads:[~2022-07-20 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 5:27 [PATCH] git-p4: fix crlf handling for utf16 files on Windows Moritz Baumann via GitGitGadget
2022-07-20 16:08 ` Junio C Hamano
2022-07-20 16:32 ` Baumann, Moritz
2022-07-20 17:18 ` Junio C Hamano
2022-07-20 18:17 ` [PATCH v2] git-p4: fix CR LF handling for utf16 files Moritz Baumann via GitGitGadget
2022-07-20 18:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7d4739sy.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=moritz.baumann@sap.com \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.