From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, me@ttaylorr.com
Subject: Re: [PATCH] clone: ignore invalid local refs in remote
Date: Thu, 21 Apr 2022 11:00:16 -0700 [thread overview]
Message-ID: <xmqq7d7ijozz.fsf@gitster.g> (raw)
In-Reply-To: <b884d627-4a81-5be9-eed5-feff3b2bd010@github.com> (Derrick Stolee's message of "Thu, 21 Apr 2022 09:29:32 -0400")
Derrick Stolee <derrickstolee@github.com> writes:
> Sorry, this title of the commit message is stale from a version
> where I started making the clones succeed (but without these
> bad refs). I changed my mind to only switch BUG() to die() to
> avoid giving the impression that we have a "matching" repo after
> the clone.
Ah, that figures ;-)
> Perhaps the commit could instead start with
>
> clone: die() instead of BUG() on bad refs
>
> ?
Yeah, it would be the title I would have been happy with.
next prev parent reply other threads:[~2022-04-21 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 17:12 [PATCH] clone: ignore invalid local refs in remote Derrick Stolee via GitGitGadget
2022-04-18 17:30 ` Ævar Arnfjörð Bjarmason
2022-04-20 20:53 ` Junio C Hamano
2022-04-21 13:29 ` Derrick Stolee
2022-04-21 18:00 ` Junio C Hamano [this message]
2022-04-25 13:47 ` [PATCH v2] clone: die() instead of BUG() on bad refs Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7d7ijozz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.