From: Junio C Hamano <gitster@pobox.com>
To: Simon Ruderich <simon@ruderich.org>
Cc: Jeff King <peff@peff.net>, Stefan Beller <sbeller@google.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Lars Schneider <larsxschneider@gmail.com>
Subject: Re: [PATCH 2/3] t5615: avoid re-using descriptor 4
Date: Sat, 21 Oct 2017 11:02:04 +0900 [thread overview]
Message-ID: <xmqq7evpgswz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171021001916.bohcqjuxcufxvpam@ruderich.org> (Simon Ruderich's message of "Sat, 21 Oct 2017 02:19:16 +0200")
Simon Ruderich <simon@ruderich.org> writes:
> On Fri, Oct 20, 2017 at 06:46:08PM -0400, Jeff King wrote:
>>> I agree. Maybe just stick with the original patch?
>>
>> OK. Why don't we live with that for now, then. The only advantage of the
>> "999" trickery is that it's less likely to come up again. If it doesn't,
>> then we're happy. If it does, then we can always switch then.
>
> I think switching the 4 to 9 (which you already brought up in
> this thread) is a good idea. It makes accidental conflicts less
> likely (it's rare to use so many file descriptors) and is easy to
> implement.
Yeah, I like the simplicity of implementation, and I more like the
fact that it is simpler to reason about its limitation.
next prev parent reply other threads:[~2017-10-21 2:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 21:01 [PATCH 0/3] making test-suite tracing more useful Jeff King
2017-10-19 21:03 ` [PATCH 1/3] test-lib: silence "-x" cleanup under bash Jeff King
2017-10-19 21:07 ` [PATCH 2/3] t5615: avoid re-using descriptor 4 Jeff King
2017-10-19 21:46 ` Stefan Beller
2017-10-19 23:23 ` Jeff King
2017-10-20 5:50 ` Jeff King
2017-10-20 21:27 ` Stefan Beller
2017-10-20 22:46 ` Jeff King
2017-10-21 0:19 ` Simon Ruderich
2017-10-21 2:02 ` Junio C Hamano [this message]
2017-10-21 3:23 ` Jeff King
2017-10-19 21:08 ` [PATCH 3/3] test-lib: make "-x" work with "--verbose-log" Jeff King
2017-10-23 10:56 ` Johannes Schindelin
2017-10-20 22:53 ` [PATCH 4/3] t/Makefile: introduce TEST_SHELL_PATH Jeff King
2017-10-20 23:50 ` SZEDER Gábor
2017-10-21 3:12 ` Jeff King
2017-10-23 11:01 ` Johannes Schindelin
2017-10-24 1:31 ` Jeff King
2017-10-25 21:35 ` Johannes Schindelin
2017-10-25 21:50 ` Jeff King
2017-10-27 14:26 ` Johannes Schindelin
2017-10-23 11:04 ` [PATCH 0/3] making test-suite tracing more useful Johannes Schindelin
2017-10-24 1:32 ` Jeff King
2017-12-08 10:46 ` [PATCH v2 0/4] " Jeff King
2017-12-08 10:47 ` [PATCH v2 1/4] test-lib: silence "-x" cleanup under bash Jeff King
2017-12-08 10:47 ` [PATCH v2 2/4] t5615: avoid re-using descriptor 4 Jeff King
2017-12-08 10:47 ` [PATCH v2 3/4] test-lib: make "-x" work with "--verbose-log" Jeff King
2017-12-08 10:47 ` [PATCH v2 4/4] t/Makefile: introduce TEST_SHELL_PATH Jeff King
2017-12-08 15:08 ` Johannes Schindelin
2017-12-08 22:00 ` Jeff King
2017-12-09 13:44 ` Johannes Schindelin
2017-12-10 14:23 ` Jeff King
2017-12-11 20:37 ` Junio C Hamano
2017-12-15 10:41 ` Jeff King
2017-12-15 16:58 ` Junio C Hamano
2017-12-21 9:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7evpgswz.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=simon@ruderich.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.