From: Junio C Hamano <gitster@pobox.com>
To: Dan Kohn <dan@linuxfoundation.org>
Cc: git@vger.kernel.org
Subject: Re: Request for git merge --signoff
Date: Sat, 01 Jul 2017 13:25:29 -0700 [thread overview]
Message-ID: <xmqq7ezroqfa.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAHv71zJZfG3AGNL_J5KqYiut6AyyNdUyBG-sZ9aZ-zoGVdOr+w@mail.gmail.com> (Dan Kohn's message of "Sat, 1 Jul 2017 14:15:57 -0400")
Dan Kohn <dan@linuxfoundation.org> writes:
> On Sat, Jul 1, 2017 at 1:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Dan Kohn <dan@linuxfoundation.org> writes:
>
>>> Could you please add a `--signoff` option to `git merge`?
>
>> The reason why we changed the default for "git merge" to start an
>> editor at around v1.7.10 was because we wanted to encourage people
>> to write log message that more meaningfully documents the change,
>> and adding sign-off is probably in line with that.
>
>> I've done that "commit --amend" on a merge to tweak its message
>> myself number of times, but I have to admit that I never did so for
>> sign-off, but why not? ;-)
>
> I'm not opposed to starting the editor, although ...
> ...
> Even if you turn down my request for a new flag here,...
Was I a bit too oblique? I said that do think "merge --signoff" is
in line with the latest philosophy, i.e. not rejecting the idea of
add such an option. IOW, patches welcome (either from you or other
people).
next prev parent reply other threads:[~2017-07-01 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 15:24 Request for git merge --signoff Dan Kohn
2017-07-01 17:45 ` Junio C Hamano
2017-07-01 18:15 ` Dan Kohn
2017-07-01 20:25 ` Junio C Hamano [this message]
2017-07-01 22:15 ` Ævar Arnfjörð Bjarmason
2017-07-25 5:42 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7ezroqfa.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dan@linuxfoundation.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.