From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Philip Oakley <philipoakley@iee.org>,
Stefan Beller <sbeller@google.com>,
Orgad Shaneh <orgads@gmail.com>,
Dakota Hawkins <dakotahawkins@gmail.com>,
git <git@vger.kernel.org>
Subject: Re: Submodule/contents conflict
Date: Sun, 30 Apr 2017 17:15:03 -0700 [thread overview]
Message-ID: <xmqq7f21l9fc.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170428083015.m2vowojjcdgfkcak@sigill.intra.peff.net> (Jeff King's message of "Fri, 28 Apr 2017 04:30:15 -0400")
Jeff King <peff@peff.net> writes:
> Interestingly, I would have thought that the first update-index call
> would "de-racify" the entry by rewriting the index. But we don't
> actually write, presumably because we eventually realize that there are
> no entries to update. But it might actually be worth doing the write,
> because it avoids further file-content reads later on (and most
> workflows tend to do a lot of reads; every git-status is going to rehash
> the file until the next index update).
Yeah, there is a tradeoff of time being spent on writing the index
(which could be large) and having to rehash the content (which could
also have to happen number of times until the next index writeout),
and in hindsight I suspect that I got the tradeoff wrong when we did
the racy-git-avoidance thing.
next prev parent reply other threads:[~2017-05-01 0:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 8:06 Submodule/contents conflict Orgad Shaneh
2017-04-24 17:40 ` Stefan Beller
2017-04-24 23:33 ` Philip Oakley
2017-04-24 23:43 ` Stefan Beller
2017-04-25 3:22 ` Jeff King
2017-04-25 3:39 ` Jeff King
2017-04-27 22:52 ` Philip Oakley
2017-04-28 8:30 ` Jeff King
2017-05-01 0:15 ` Junio C Hamano [this message]
2017-04-25 11:10 ` Philip Oakley
2017-04-26 2:51 ` Junio C Hamano
2017-04-26 17:41 ` Stefan Beller
2017-04-27 0:25 ` Junio C Hamano
2017-04-27 0:29 ` Junio C Hamano
2017-04-27 22:07 ` Philip Oakley
2017-04-28 2:08 ` Junio C Hamano
2017-04-25 2:12 ` Junio C Hamano
2017-04-25 15:57 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7f21l9fc.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dakotahawkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=orgads@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.