From: Junio C Hamano <gitster@pobox.com>
To: Charles Bailey <charles@hashpling.org>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] grep: fix grepping for "intent to add" files
Date: Thu, 16 Jun 2016 11:12:15 -0700 [thread overview]
Message-ID: <xmqq7fdp57gg.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160616065324.GA14967@hashpling.org> (Charles Bailey's message of "Thu, 16 Jun 2016 07:53:24 +0100")
Charles Bailey <charles@hashpling.org> writes:
> http://thread.gmane.org/gmane.comp.version-control.git/272363/focus=276358
>
> http://thread.gmane.org/gmane.comp.version-control.git/283001/focus=283002
>
> Unless I've misunderstood the conversation and commit message, the
> referenced commit was supposed to be a "code as a comment" commit with
> no change in observable behavior
Thanks for a pointer; 276358 claims that ce->ce_mode would be zero
for path added with "git add -N path", but I do not think it is
correct.
The updated behaviour is more understandable. With "add -N", the
user said "Just keep an eye on this path, I cannot decide what the
contents for this path in the index should be at this moment".
grep_cache() that checks the contents in the index cannot say what
is in the index, because the contents is not yet there.
prev parent reply other threads:[~2016-06-16 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 6:53 [PATCH] grep: fix grepping for "intent to add" files Charles Bailey
2016-06-16 7:47 ` Duy Nguyen
2016-06-16 9:47 ` Charles Bailey
2016-06-16 10:57 ` Duy Nguyen
2016-06-16 11:44 ` Charles Bailey
2016-06-16 12:11 ` Duy Nguyen
2016-06-16 18:18 ` Junio C Hamano
2016-06-16 18:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fdp57gg.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.