From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: pclouds@gmail.com, git@vger.kernel.org
Subject: Re: [RFC PATCH] pathspec: get non matching arguments without reporting.
Date: Thu, 05 May 2016 16:11:52 -0700 [thread overview]
Message-ID: <xmqq7ff885hj.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1462489197-30616-1-git-send-email-sbeller@google.com> (Stefan Beller's message of "Thu, 5 May 2016 15:59:57 -0700")
Stefan Beller <sbeller@google.com> writes:
> When giving more than just pathspec arguments (e.g. submodule labels),
> we need a way to check all non-matching arguments for the pathspec parsing
> if these are the submodule labels or typos.
>
> This patch prepares for that use case by splitting up `report_path_error`
> into a new checking function `unmatched_pathspec_items` and a
> reporting callback.
I seem to recall that there is a longstanding plan to move the
"seen[]" array that is separate and outside from the pathspec
structure into the pathspec structure. Wouldn't that be a more
sensible approach to solve the same thing?
next prev parent reply other threads:[~2016-05-05 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 22:59 [RFC PATCH] pathspec: get non matching arguments without reporting Stefan Beller
2016-05-05 23:11 ` Junio C Hamano [this message]
2016-05-05 23:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7ff885hj.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.