From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, norio.nomura@gmail.com
Subject: Re: [PATCH 0/4] Fix relative path issues in recursive submodules.
Date: Thu, 31 Mar 2016 10:04:00 -0700 [thread overview]
Message-ID: <xmqq7fgipojj.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1459383457-6848-1-git-send-email-sbeller@google.com> (Stefan Beller's message of "Wed, 30 Mar 2016 17:17:33 -0700")
Stefan Beller <sbeller@google.com> writes:
> It took me longer than expected to fix this bug.
>
> It comes with a test and minor refactoring and applies on top of
> origin/sb/submodule-helper, such that it can be merged into 2.7, 2.8 as well
> as master.
>
> Patch 1 is a test which fails; it has a similar layout as the
> real failing repository Norio Nomura pointed out, but simplified to the
> bare essentials for reproduction of the bug.
>
> Patch 2&3 are not strictly necessary for fixing the isseu, but it removes
> stupid code I wrote, so the resulting code looks a little better.
>
> Patch 4 fixes the issue by giving more information to relative_path,
> such that a relative path can be found in all cases.
There were some minor nits, but I saw nothing glaringly wrong to
break the topic. Thanks for working on this.
next prev parent reply other threads:[~2016-03-31 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 0:17 [PATCH 0/4] Fix relative path issues in recursive submodules Stefan Beller
2016-03-31 0:17 ` [PATCH 1/4] recursive submodules: test for relative paths Stefan Beller
2016-03-31 16:33 ` Junio C Hamano
2016-03-31 16:47 ` Stefan Beller
2016-03-31 0:17 ` [PATCH 2/4] submodule--helper clone: simplify path check Stefan Beller
2016-03-31 0:32 ` Jacob Keller
2016-03-31 7:31 ` Eric Sunshine
2016-03-31 17:17 ` Stefan Beller
2016-03-31 16:36 ` Junio C Hamano
2016-03-31 17:04 ` Eric Sunshine
2016-03-31 0:17 ` [PATCH 3/4] submodule--helper clone: remove double path checking Stefan Beller
2016-03-31 16:44 ` Junio C Hamano
2016-03-31 0:17 ` [PATCH 4/4] submodule--helper: use relative path if possible Stefan Beller
2016-03-31 16:59 ` Junio C Hamano
2016-03-31 19:22 ` Stefan Beller
2016-03-31 17:04 ` Junio C Hamano [this message]
2016-03-31 17:20 ` [PATCH 0/4] Fix relative path issues in recursive submodules Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fgipojj.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=norio.nomura@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.