All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Jeff King <peff@peff.net>,
	Trevor Saunders <tbsaunde@tbsaunde.org>,
	Stefan Beller <sbeller@google.com>,
	"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] bisect: print abbrev sha1 for first bad commit
Date: Tue, 12 May 2015 10:11:42 -0700	[thread overview]
Message-ID: <xmqq7fsd201d.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAP8UFD3LzM3uuUzWYS-o6mhtH-x5+-kyGhDvYnv6ZPRTC18C6w@mail.gmail.com> (Christian Couder's message of "Tue, 12 May 2015 11:21:57 +0200")

Christian Couder <christian.couder@gmail.com> writes:

> On Mon, May 11, 2015 at 6:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> To be bluntly honest, I think the current one is sufficient as a
>> good-enough default.  The first thing I would do after seeing that
>> message is to either "git checkout <commit-object-name>" or "git
>> show <commit-object-name>", and the current full 40-hex output gives
>> me an easier mouse-double-click target than the proposed abbreviated
>> one, so in that sense the original proposal may even be a usability
>> regression.
>
> Yeah, it might also be a regression if some users have scripts that
> depend on the current behavior.
> ...
>> It is tempting to say that the output can be eliminated by always
>> checking out the first-bad-commit (i.e. only when the last answer
>> that led to the first-bad decision was "good", do a "git checkout"
>> of that bad commit), but in a project where a branch switching is
>> not instantaneous, that might be problematic (unless the first step
>> the user would have done is to check it out anyway, of course).
>
> Yeah, and speaking of regressions, elimiting the output might be a
> more serious regression.

I am getting somewhat annoyed by this line of thought.

Who said bisect output is meant to be parseable and be read by
scripts in the first place?  If that were the case, we wouldn't be
having this discussion thread in the first place.

  reply	other threads:[~2015-05-12 17:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 23:46 [PATCH] bisect: print abbrev sha1 for first bad commit Trevor Saunders
2015-05-09  0:29 ` Stefan Beller
2015-05-09  2:03   ` Trevor Saunders
2015-05-09  4:07     ` Jeff King
2015-05-10 23:12       ` Trevor Saunders
2015-05-11  1:10         ` Jeff King
2015-05-11  4:33           ` Junio C Hamano
2015-05-11  7:38             ` Christian Couder
2015-05-11 16:54               ` Junio C Hamano
2015-05-11 18:17                 ` Trevor Saunders
2015-05-11 18:28                   ` Stefan Beller
2015-05-12  9:21                 ` Christian Couder
2015-05-12 17:11                   ` Junio C Hamano [this message]
2015-05-12 20:43                     ` Christian Couder
2015-05-12 20:58                       ` Stefan Beller
2015-05-12 23:40                         ` Trevor Saunders
2015-05-13 13:24                           ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7fsd201d.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    --cc=tbsaunde@tbsaunde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.