From: Junio C Hamano <gitster@pobox.com>
To: Manos Pitsidianakis <epilys@norn.io>
Cc: Dongcan Jiang <dongcan.jiang@gmail.com>,
Git List <git@vger.kernel.org>,
me@ikke.info, "brian m. carlson" <sandals@crustytoothpaste.net>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v3] log: forbid log --graph --no-walk
Date: Mon, 16 Mar 2015 12:08:21 -0700 [thread overview]
Message-ID: <xmqq7fugrc9m.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <55072856.5090308@norn.io> (Manos Pitsidianakis's message of "Mon, 16 Mar 2015 21:00:38 +0200")
Manos Pitsidianakis <epilys@norn.io> writes:
> On 03/15/2015 03:39 AM, Dongcan Jiang wrote:
>> Because "revs->no_walk" gets set when it comes to "git show".
>
> So basically rewriting t4052-stat-output.sh to exclude git show --graph
> cases (or similar) is not enough. If rewriting git-show code is what is
> needed, is that in the scope of a microproject?
Perhaps 13b25381 (revision: forbid combining --graph and --no-walk,
2015-03-11) that is queued on 'pu' would be a good answer to this
question?
next prev parent reply other threads:[~2015-03-16 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <md5:DbynqDqKsm8mpedJ3B12rw==>
2015-03-15 0:43 ` [PATCH v3] log: forbid log --graph --no-walk Manos Pitsidianakis
2015-03-15 1:08 ` Dongcan Jiang
2015-03-15 1:24 ` Manos Pitsidianakis
2015-03-15 1:39 ` Dongcan Jiang
2015-03-16 19:00 ` Manos Pitsidianakis
2015-03-16 19:08 ` Junio C Hamano [this message]
2015-03-16 19:15 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fugrc9m.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dongcan.jiang@gmail.com \
--cc=epilys@norn.io \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.