All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] contrib: remote-helpers: add move warnings (v2.0)
Date: Tue, 13 May 2014 15:02:40 -0700	[thread overview]
Message-ID: <xmqq7g5pmj5r.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1400016596-13178-1-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Tue, 13 May 2014 16:29:56 -0500")

Felipe Contreras <felipe.contreras@gmail.com> writes:

> The tools are now maintained out-of-tree, and they have a regression in
> v2.0.

You seem not to understand at all what a regression is.

My understanding is that versions of remote-hg shipped with all
versions of Git did not work with Hg 3.0, so not working with Hg 3.0
is a regression in v2.0 at all.  A recent report was about Hg 3.0
not working with 1.9.3, but I think you earlier said all versions of
Git does not work with Hg 3.0, and I can believe it.  That is hardly
a regression.

You could argue that Hg has a new regression to its external users
of its API when it went to 3.0.  We actually had a similar breakage
in 1.5.4, where it was reported late in the cycle after -rc0 [*1*]
that cgit that linked with our internal API libgit.a was broken by a
change on our side, which resulted in us fixing the breakage (even
though technically you may be able to say that it was cgit's fault
to link with libgit.a in the first place) with 18125644 (Move
sha1_file_to_archive into libgit, 2008-01-14) very late in the
cycle.  Calling that a regression in cgit would have been insane,
even if we did not patch our side up to accomodate it.

Stop this idiocy.


[References]

*1* http://thread.gmane.org/gmane.comp.version-control.git/70117/focus=71064

  reply	other threads:[~2014-05-13 22:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 21:29 [PATCH] contrib: remote-helpers: add move warnings (v2.0) Felipe Contreras
2014-05-13 22:02 ` Junio C Hamano [this message]
2014-05-13 22:22   ` Felipe Contreras
2014-05-13 22:41     ` Junio C Hamano
2014-05-13 22:47       ` Felipe Contreras
2014-05-14  2:16         ` Marius Storm-Olsen
2014-05-14 19:06           ` Junio C Hamano
2014-05-14 19:39             ` Felipe Contreras
2014-05-14 20:21               ` Junio C Hamano
2014-05-14 20:51                 ` Felipe Contreras
2014-05-13 23:11     ` Ronnie Sahlberg
2014-05-13 23:37       ` Felipe Contreras
2014-05-14 16:57         ` Ronnie Sahlberg
2014-05-14 19:26           ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7g5pmj5r.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.