From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Elia Pinto <gitter.spiros@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution
Date: Mon, 28 Apr 2014 12:20:07 -0700 [thread overview]
Message-ID: <xmqq7g69qn14.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqmwf572fx.fsf@anie.imag.fr> (Matthieu Moy's message of "Mon, 28 Apr 2014 20:07:30 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>>
>>>> CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
>>>> -e 's/^Signed-off-by: \(.*\)/\1,/gp'`
>>>
>>> It looks like you may have missed a usage here due to the line break.
>>
>> Good eyes ;-)
>>
>> The following may be an obvious replacement patch, but alternatively
>> we could just drop the whole thing (contrib/ material is not
>> something we would need to police strictly for the style---nobody
>> should be mimicking their styles as they are not part of _our_
>> codebase in the first place).
>
> My vote goes for keeping the patch as it is, so that future people
> grepping for `...` construct do not find any after the series is
> finished.
>
> (and because it's simple to do)
Sure, let's do that.
next prev parent reply other threads:[~2014-04-28 19:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 13:43 [PATCH 01/14] t9365-continuing-queries.sh: use the $( ... ) construct for command substitution Elia Pinto
2014-04-23 13:43 ` [PATCH 02/14] test-gitmw-lib.sh: " Elia Pinto
2014-04-23 13:43 ` [PATCH 03/14] t7900-subtree.sh: " Elia Pinto
2014-04-23 13:43 ` [PATCH 04/14] appp.sh: " Elia Pinto
2014-04-25 22:58 ` brian m. carlson
2014-04-28 17:53 ` Junio C Hamano
2014-04-28 18:07 ` Matthieu Moy
2014-04-28 19:20 ` Junio C Hamano [this message]
2014-04-23 13:43 ` [PATCH 05/14] txt-to-pot.sh: " Elia Pinto
2014-04-23 14:44 ` Matthieu Moy
2014-04-23 13:43 ` [PATCH 06/14] git-pull.sh: " Elia Pinto
2014-04-23 13:43 ` [PATCH 07/14] git-rebase--merge.sh: " Elia Pinto
2014-04-23 13:44 ` [PATCH 08/14] git-rebase.sh: " Elia Pinto
2014-04-23 13:44 ` [PATCH 09/14] git-stash.sh: " Elia Pinto
2014-04-23 13:44 ` [PATCH 10/14] git-web--browse.sh: " Elia Pinto
2014-04-23 13:44 ` [PATCH 11/14] lib-credential.sh: " Elia Pinto
2014-04-23 13:44 ` [PATCH 12/14] lib-cvs.sh: " Elia Pinto
2014-04-23 13:44 ` [PATCH 13/14] lib-gpg.sh: " Elia Pinto
2014-04-23 13:44 ` [PATCH 14/14] p5302-pack-index.sh: " Elia Pinto
2014-04-23 14:45 ` [PATCH 01/14] t9365-continuing-queries.sh: " Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7g69qn14.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.