All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jonas Bang" <email@jonasbang.dk>
Cc: <git@vger.kernel.org>
Subject: Re: Git feature request: Option to force Git to abort a checkout if working directory is dirty (i.e. disregarding the check for conflicts)
Date: Wed, 02 Apr 2014 10:55:59 -0700	[thread overview]
Message-ID: <xmqq7g77vcnk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <002a01cf4dd3$d88c8640$89a592c0$@jonasbang.dk> (Jonas Bang's message of "Tue, 1 Apr 2014 19:57:26 +0200")

"Jonas Bang" <email@jonasbang.dk> writes:

>> >> ...  The default behaviour would cover their
>> >> use case so your proposal would not hurt them, but I wonder if there
>> >> are things you could do to help them as well, perhaps by allowing
>> >> this new configuration to express something like "local changes in
>> >> these paths are excempt from this new check".
>> >
>> > Yes, those people would probably use the default 'false' behavior as
>> > it is already. If they however would like to use e.g. the 'true' or
>> > 'include-untracked' setting as a configuration variable, then they can
>> > use the command line option 'false' if they wish to do a 'git
>> > checkout' even with modified files in the working tree.
>> 
>> So in short, you are saying that "The added code necessary to implement
>> this feature will not help them in any way, it is just that we
>> will make sure it does not hurt them".
>
> I didn't realize they needed help.

If so, then you could have just stated that way, instead of saying
they have an escape hatch ;-)

It is perfectly fine to answer to "I wonder if there are things you
could do?" with "No, I am not going to help them with this series; I
only make sure I do not hurt them."  and that is perfectly fine, as
long as:

 - you do not directly hurt them with your series; and

 - you do not make it harder for those who are interested in helping
   them to build on top of your work in the future.

> How and who to decide if this is a reasonable feature request to accept?

As this project primarily works on "scratch your own itch" basis,
somebody who (1) thinks that the proposed feature is worth having in
our system and (2) is interested in working on it will pick it up.

If nobody is interested, then usually nothing happens.

  reply	other threads:[~2014-04-03 10:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 16:15 Git feature request: Option to force Git to abort a checkout if working directory is dirty (i.e. disregarding the check for conflicts) Jonas Bang
2014-03-27 17:46 ` Junio C Hamano
2014-03-29 11:49   ` Jonas Bang
2014-03-31 17:13     ` Junio C Hamano
2014-04-01 17:57       ` Jonas Bang
2014-04-02 17:55         ` Junio C Hamano [this message]
2014-04-03 18:42           ` Jonas Bang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7g77vcnk.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=email@jonasbang.dk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.