From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Sverre Rabbelier <srabbelier@gmail.com>,
Richard Hansen <rhansen@bbn.com>
Subject: Re: [PATCH v6 03/10] transport-helper: add 'force' to 'export' helpers
Date: Mon, 11 Nov 2013 15:28:26 -0800 [thread overview]
Message-ID: <xmqq7gcejyuc.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: 1384210507-26561-7-git-send-email-felipe.contreras@gmail.com
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Otherwise they cannot know when to force the push or not (other than
> hacks).
>
> Tests-by: Richard Hansen <rhansen@bbn.com>
> Documentation-by: Richard Hansen <rhansen@bbn.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
Didn't we agree that this should be warn, not die?
> + if (flags & TRANSPORT_PUSH_FORCE) {
> + if (set_helper_option(transport, "force", "true") != 0)
> + die("helper %s does not support 'force'", data->name);
> + }
> +
> helper = get_helper(transport);
>
> write_constant(helper->in, "export\n");
next prev parent reply other threads:[~2013-11-11 23:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 22:54 [PATCH v6 10/10] transport-helper: add support to delete branches Felipe Contreras
2013-11-11 22:54 ` [PATCH v6 00/10] transport-helper: updates Felipe Contreras
2013-11-11 23:33 ` Junio C Hamano
2013-11-11 23:44 ` Felipe Contreras
2013-11-11 23:37 ` Junio C Hamano
2013-11-12 6:21 ` Richard Hansen
2013-11-12 20:55 ` Felipe Contreras
2013-11-12 7:03 ` [PATCH v2] remote-bzr: support the new 'force' option Richard Hansen
2013-11-12 21:01 ` Felipe Contreras
2013-11-11 22:54 ` [PATCH v6 01/10] transport-helper: fix extra lines Felipe Contreras
2013-11-11 22:55 ` [PATCH v6 08/10] fast-import: add support to delete refs Felipe Contreras
2013-11-11 22:55 ` [PATCH v6 05/10] fast-export: improve argument parsing Felipe Contreras
2013-11-11 22:55 ` [PATCH v6 06/10] fast-export: add new --refspec option Felipe Contreras
2013-11-11 23:25 ` Junio C Hamano
2013-11-11 23:50 ` Felipe Contreras
2013-11-12 7:39 ` Richard Hansen
2013-11-12 17:08 ` Junio C Hamano
2013-11-12 21:02 ` Felipe Contreras
2013-11-12 21:46 ` Junio C Hamano
2013-11-12 23:20 ` Felipe Contreras
2013-11-12 23:54 ` Junio C Hamano
2013-12-07 10:00 ` Felipe Contreras
2013-12-09 21:00 ` Junio C Hamano
2013-12-09 21:11 ` Junio C Hamano
2014-04-24 3:55 ` Felipe Contreras
2013-11-11 22:55 ` [PATCH v6 03/10] transport-helper: add 'force' to 'export' helpers Felipe Contreras
2013-11-11 23:28 ` Junio C Hamano [this message]
2013-11-11 23:47 ` Felipe Contreras
2013-11-11 22:55 ` [PATCH v6 09/10] fast-export: add support to delete refs Felipe Contreras
2013-11-11 22:55 ` [PATCH v6 07/10] transport-helper: add support for old:new refspec Felipe Contreras
2013-11-11 22:55 ` [PATCH v6 04/10] transport-helper: check for 'forced update' message Felipe Contreras
2013-11-11 22:55 ` [PATCH v6 02/10] transport-helper: don't update refs in dry-run Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7gcejyuc.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=rhansen@bbn.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.